From: sashiko-bot@kernel.org
To: "Gu Bin" <gubin@cmss.chinamobile.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] tools/leds/uledmon: force NUL-termination of device name
Date: Fri, 06 Nov 2026 10:09:24 +0000 [thread overview]
Message-ID: <sashiko-outbox-201187@kernel.org> (raw)
In-Reply-To: <20261106100614.2312-1-gubin@cmss.chinamobile.com>
> strncpy() does not NUL-terminate when the source is at least as long
> as the bound. uleds_dev.name is passed to the kernel with
> write(fd, &uleds_dev, sizeof(uleds_dev)), so a >= LED_MAX_NAME_SIZE
> byte argv[1] leaves name without a terminator and the write sends
> trailing bytes that are not part of a valid device name.
>
> Force NUL-termination after the strncpy.
>
> Fixes: fa7f32422ea1 ("tools/leds: Add uledmon program for monitoring userspace LEDs")
> Signed-off-by: Gu Bin <gubin@cmss.chinamobile.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261106100614.2312-1-gubin@cmss.chinamobile.com?part=1
next prev parent reply other threads:[~2026-11-06 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-06 10:06 [PATCH] tools/leds/uledmon: force NUL-termination of device name Gu Bin
2026-11-06 10:09 ` sashiko-bot [this message]
2026-11-06 14:05 ` David Lechner
2026-11-09 7:05 ` [PATCH v2] tools/leds/uledmon: reject device names that are too long Gu Bin
2026-11-09 7:11 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-201187@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=gubin@cmss.chinamobile.com \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox