From: sashiko-bot@kernel.org
To: "Michiel van Beers" <michielvanbeers@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v2 2/2] backlight: lm3630a: Allow setting the full-scale current per bank
Date: Wed, 11 Nov 2026 16:50:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-209330@kernel.org> (raw)
In-Reply-To: <20261111-lm3630a-led-max-microamp-v2-2-aff11756e7be@gmail.com>
> From: Michiel van Beers <michielvanbeers@gmail.com>
>
> The driver always programs the full-scale current of both control banks
> to the maximum of 28.25 mA (code 0x1F). Boards whose LED strings are
> rated for less have no way to lower it.
>
> Read the optional led-max-microamp property of each led@ node and
> program the full-scale current register of that bank with the matching
> code, I_FS = 5 mA + code * 0.75 mA (datasheet SNVS974B, 7.3.1.11). The
> code is rounded down, so the current never exceeds the requested value.
> Values outside 5000 to 28250 uA are rejected with -EINVAL.
>
> Without the property the driver still programs 0x1F, so existing boards
> are unaffected.
>
> Signed-off-by: Michiel van Beers <michielvanbeers@gmail.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261111-lm3630a-led-max-microamp-v2-0-aff11756e7be@gmail.com?part=2
prev parent reply other threads:[~2026-11-11 16:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-11 16:21 [PATCH v2 0/2] backlight: lm3630a: Add a per-bank full-scale current limit Michiel van Beers via B4 Relay
2026-11-11 16:21 ` [PATCH v2 1/2] dt-bindings: backlight: lm3630a: Add led-max-microamp Michiel van Beers via B4 Relay
2026-11-11 16:48 ` sashiko-bot
2026-11-12 11:05 ` Krzysztof Kozlowski
2026-11-11 16:21 ` [PATCH v2 2/2] backlight: lm3630a: Allow setting the full-scale current per bank Michiel van Beers via B4 Relay
2026-11-11 16:50 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-209330@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=michielvanbeers@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox