Re: [PATCH v2] video: leds: backlight: lm3533: Support getting LED sources from DT

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [High] leds: lm3533: logical AND instead of bitwise AND in
  lm3533_led_setup()
--

commit 2dcd9488633f844daaa29902962d2a0a3e964633
Author: Svyatoslav Ryhel <clamor95@gmail.com>

video: leds: backlight: lm3533: Support getting LED sources from DT

This commit adds support for configuring LM3533 Control Bank to HVLED and
LVLED output muxing from the led-sources Device Tree property.

> diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
> index d5997cbd88dfc..72fc839d8b604 100644
> --- a/drivers/leds/leds-lm3533.c
> +++ b/drivers/leds/leds-lm3533.c
> @@ -26,6 +26,13 @@
>  #define LM3533_ALS_CHANNEL_LV_MIN	1
>  #define LM3533_ALS_CHANNEL_LV_MAX	2
>  
> +#define LM3533_REG_OUTPUT_CONF1			0x10
> +#define   OUTPUT_CONF1_SHIFT			2
> +#define   OUTPUT_LVLED_MASK			0x3
> +#define   OUTPUT_CONF1_PREP(x)			(((x) << OUTPUT_CONF1_SHIFT) && 0xff)
> +#define LM3533_REG_OUTPUT_CONF2			0x11
> +#define   OUTPUT_CONF2_SHIFT			6
> +#define   OUTPUT_CONF2_PREP(x)			(((x) >> OUTPUT_CONF2_SHIFT) && 0xff)

[Severity: High]
Should OUTPUT_CONF1_PREP() and OUTPUT_CONF2_PREP() use bitwise AND (& 0xff)
instead of logical AND (&& 0xff)?

With && 0xff, both macros evaluate to 0 or 1, so lm3533_led_setup() passes a
mask of 0x01 to regmap_update_bits() on LM3533_REG_OUTPUT_CONF1 and
LM3533_REG_OUTPUT_CONF2.  That leaves LVLED1..LVLED5 unconfigured and
overwrites bit 0 of LM3533_REG_OUTPUT_CONF1, which controls HVLED1 backlight
muxing.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112081941.41363-1-clamor95@gmail.com?part=1