Re: [PATCH v3 1/7] platform/x86: thinkpad_acpi: Report auto keyboard backlight mode as off

[sashiko-bot@kernel.org]

> The EC keyboard backlight level 3, which selects the auto mode, is
> passed to the LED classdev verbatim by kbdlight_sysfs_get().  The LED
> then reports a brightness of 3 with max_brightness 2, both through the
> brightness sysfs attribute and through brightness_hw_changed
> notifications.
> 
> This is not only cosmetic: UPower 1.91.x treats the out-of-range value as
> invalid and stops watching brightness_hw_changed altogether, so the desktop
> stops following the Fn+Space hotkey once auto mode has been entered.
> 
> The auto mode is not a brightness level.  Map it to 0, the value it is
> reported as most of the time anyway, in line with what ideapad-laptop
> already does for its auto mode.
> 
> Fixes: bb28f3d51ff5 ("thinkpad_acpi: Add support for keyboard backlight")
> Reported-by: Andrea Rabbaglietti <rabbagliettiandrea@gmail.com>
> Closes: https://lore.kernel.org/r/CAENjc+w0Rqy=kDSew7XtNJCSvyPiXPJ5faWdmCr5RGYFhpunCA@mail.gmail.com
> Cc: stable@vger.kernel.org
> Signed-off-by: Qiling Zhu <kmatzkaczor244@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261114174814.62153-1-kmatzkaczor244@gmail.com?part=1