From: sashiko-bot@kernel.org
To: "Peter LaDow" <pladow@gmail.com>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH] leds: lp5860: Add I2C interface support
Date: Fri, 20 Nov 2026 17:02:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-225618@kernel.org> (raw)
In-Reply-To: <20261120-add-i2c-support-for-lp5860-v1-1-30bc97dcbf78@gmail.com>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] leds: lp5860: positional initializer in lp5860_i2c_ids device ID
table
--
commit b60cc329b5ce4824a3e19368031ceb4e1c01c7d5
Author: Peter LaDow <pladow@gmail.com>
leds: lp5860: Add I2C interface support
This commit adds an I2C bus driver for the Texas Instruments LP5860 RGB
LED matrix driver.
> diff --git a/drivers/leds/rgb/leds-lp5860-i2c.c b/drivers/leds/rgb/leds-lp5860-i2c.c
> new file mode 100644
> index 0000000000000..2744ac3258621
> --- /dev/null
> +++ b/drivers/leds/rgb/leds-lp5860-i2c.c
> @@ -0,0 +1,139 @@
[ ... ]
> +static const struct i2c_device_id lp5860_i2c_ids[] = {
> + { "lp5860" },
> + {}
> +};
> +MODULE_DEVICE_TABLE(i2c, lp5860_i2c_ids);
[Severity: Low]
This isn't a bug, but I2C convention is to use a named initializer
({ .name = "lp5860" }) for new struct i2c_device_id entries in
lp5860_i2c_ids[].
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120-add-i2c-support-for-lp5860-v1-1-30bc97dcbf78@gmail.com?part=1
prev parent reply other threads:[~2026-11-20 17:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 16:52 [PATCH] leds: lp5860: Add I2C interface support Peter LaDow via B4 Relay
2026-11-20 17:02 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-225618@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pladow@gmail.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox