From: sashiko-bot@kernel.org
To: "Armin Wolf" <W_Armin@gmx.de>
Cc: linux-leds@vger.kernel.org, lee@kernel.org
Subject: Re: [PATCH v2 04/10] leds: class: Create "brightness_hw_changed" attribute atomically
Date: Fri, 20 Nov 2026 21:00:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-226116@kernel.org> (raw)
In-Reply-To: <20261120204246.6645-5-W_Armin@gmx.de>
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] leds: class: missing Fixes trailer for brightness_hw_changed
creation
--
commit 613d5c59b551c09481768d315756232edb71f290
Author: Armin Wolf <W_Armin@gmx.de>
> leds: class: Create "brightness_hw_changed" attribute atomically
>
> Using device_create_file() might cause userspace applications
> listening for uevents to inspect a new LED device before the kernel
> has registered all sysfs attributes for it. This might cause those
> applications to incorrectly assume that the new LED device does not
> support the "brightness_hw_changed" attribute.
>
> Fix this by letting the device core create the sysfs attribute before
> the uevent is being send to userspace.
>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
[Severity: Low]
This fixes a uevent race introduced with brightness_hw_changed. Should
this include a Fixes tag?
Fixes: 0cb8eb30d425 ("leds: class: Add new optional brightness_hw_changed attribute")
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261120204246.6645-1-W_Armin@gmx.de?part=4
next prev parent reply other threads:[~2026-11-20 21:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-20 20:35 [PATCH v2 00/10] leds: class: Support custom sysfs groups on multicolor and flash LEDs Armin Wolf
2026-11-20 20:35 ` [PATCH v2 01/10] leds: class: Constify sysfs attributes Armin Wolf
2026-11-20 20:35 ` [PATCH v2 02/10] leds: multicolor: " Armin Wolf
2026-11-20 20:35 ` [PATCH v2 03/10] leds: flash: " Armin Wolf
2026-11-20 20:35 ` [PATCH v2 04/10] leds: class: Create "brightness_hw_changed" attribute atomically Armin Wolf
2026-11-20 21:00 ` sashiko-bot [this message]
2026-11-20 20:35 ` [PATCH v2 05/10] leds: class: Fix race condition when creating the device Armin Wolf
2026-11-20 20:35 ` [PATCH v2 06/10] leds: class: Access brightness_hw_changed exactly once Armin Wolf
2026-11-20 20:35 ` [PATCH v2 07/10] leds: class: Use correct type for brightness_hw_changed field Armin Wolf
2026-11-20 20:35 ` [PATCH v2 08/10] leds: class: Split led_classdev_register_ext() Armin Wolf
2026-11-20 20:35 ` [PATCH v2 09/10] leds: Support custom sysfs groups on multicolor and flash LEDs Armin Wolf
2026-11-20 20:35 ` [PATCH v2 10/10] leds: multicolor: Adjust maximum subled intensity during initialization Armin Wolf
2026-11-20 21:02 ` sashiko-bot
2026-11-20 21:02 ` [PATCH v2 00/10] leds: class: Support custom sysfs groups on multicolor and flash LEDs sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-226116@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=W_Armin@gmx.de \
--cc=lee@kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox