[linux-lvm] VFS-Patch

[linux-lvm] VFS-Patch

[Aman Shahi]

Hi Patrick,
I tried with both 2.4.12-ac5 and 2.4.12-ac6 yesterday.
Kernel compilation was giving error on alloc_kiovec
and free_kiovec in lvm-snap.c. I replaced them with
alloc_kiovec_sz and free_kiovec_sz and added one more
int pointer in the calls. I am not sure whether that
was proper, but I was able to compile the kernel. I
was using 2.4.11 VFS-lock patch as u said.

But when using snapshot my Machine got hung. I tried
2-3 times with both ac5 and ac6. But all the time the
machine got hund and FS got corrupted.

What might have I done wrong ?

regards,
Aman.

> >Not the reply you wanted but 2.4.12ac5 is OK with 
> > the 2.4.11 VFS-lock patch.


__________________________________________________
Do You Yahoo!?
Make a great connection at Yahoo! Personals.
http://personals.yahoo.com

Re: [linux-lvm] VFS-Patch

[Chris Mason]

On Friday, October 26, 2001 07:06:58 AM -0700 Aman Shahi
<shahi_aman@yahoo.com> wrote:

> 
> Hi Patrick,
> I tried with both 2.4.12-ac5 and 2.4.12-ac6 yesterday.
> Kernel compilation was giving error on alloc_kiovec
> and free_kiovec in lvm-snap.c. I replaced them with
> alloc_kiovec_sz and free_kiovec_sz and added one more
> int pointer in the calls. I am not sure whether that
> was proper, but I was able to compile the kernel. I
> was using 2.4.11 VFS-lock patch as u said.
> 
> But when using snapshot my Machine got hung. I tried
> 2-3 times with both ac5 and ac6. But all the time the
> machine got hund and FS got corrupted.
> 
> What might have I done wrong ?

Is this an SMP machine?  What happens when you turn on the spinlock
debugging (under the kernel debugging section in make menuconfig).

-chris

Re: [linux-lvm] VFS-Patch

[Patrick Caulfield]

On Fri, Oct 26, 2001 at 07:06:58AM -0700, Aman Shahi wrote:
> 
> Hi Patrick,
> I tried with both 2.4.12-ac5 and 2.4.12-ac6 yesterday.
> Kernel compilation was giving error on alloc_kiovec
> and free_kiovec in lvm-snap.c. I replaced them with
> alloc_kiovec_sz and free_kiovec_sz and added one more
> int pointer in the calls. I am not sure whether that
> was proper, but I was able to compile the kernel. I
> was using 2.4.11 VFS-lock patch as u said.
> 
> But when using snapshot my Machine got hung. I tried
> 2-3 times with both ac5 and ac6. But all the time the
> machine got hund and FS got corrupted.
> 
> What might have I done wrong ?

That last parameter to alloc/free_kiovec_sz is the size of the
vector - it should be a pointer to an int that has the value
KIO_MAX_SECTORS

eg:


        int ret, max_sectors;
        int nbhs = KIO_MAX_SECTORS;

        /* allocate kiovec to do chunk io */
        ret = alloc_kiovec_sz(1, &lv_snap->lv_iobuf, &nbhs);
        if (ret) goto out;

        max_sectors = KIO_MAX_SECTORS << (PAGE_SHIFT-9);

        ret = lvm_snapshot_alloc_iobuf_pages(lv_snap->lv_iobuf, max_sectors);
        if (ret) goto out_free_kiovec;

        /* allocate kiovec to do exception table io */
        ret = alloc_kiovec_sz(1, &lv_snap->lv_COW_table_iobuf, &nbhs);
        if (ret) goto out_free_kiovec;


Unfortunatley there's no sensible way in the patch builder to detect an ac
kernel that has this API change so it can;t be done automatically at present.




patrick

[linux-lvm] What is VFS

[Mitch Miller]

Can somebody help me out?  On a Linux box (Redhat 7.1, Kernel 2.4.12) I've
started seeing VFS: Disk change detected on device sr(11,?) where ? is
either 0 or 1 (they're usually in pairs, once with a 0 and once with a 1).

I guess I'm not _for_sure_ what VFS is, and why it'd be detecting so many
(literally hundreds per hour) disk changes.  I do have a standard floppy,
and a SCSI attached (Adaptec 2940) Iomega Jazz drive.  The drive has a
single LVM partition on it, but it's not currently mounted (I've not fully
implemented LVM on this box yet).

THanks,
Mitch

Re: [linux-lvm] What is VFS

[Goetz Bock]

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]


On Mon, Oct 29 '01 at 08:48, Mitch Miller wrote:
> I guess I'm not _for_sure_ what VFS is, and why it'd be detecting so many
The VFS is the virtual filesystem layer, that lies under all
FileSystems.
> (literally hundreds per hour) disk changes.  I do have a standard floppy,
I can only guess on this, maybe your (unused) JAZZ drives spinnes down
and creates a 0 (removed), than the driver spinns it up again (1) ...
> and a SCSI attached (Adaptec 2940) Iomega Jazz drive.  The drive has a
> single LVM partition on it, but it's not currently mounted (I've not fully
> implemented LVM on this box yet).

-- 
Goetz Bock                                              IT Consultant
Dipl.-Inf. Univ.

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]