linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Dave Wysochanski <dwysocha@redhat.com>
To: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] Bug in error code for  lvm_vg_open()
Date: Mon, 22 Nov 2010 23:03:15 -0500	[thread overview]
Message-ID: <1290484995.31336.1.camel@f12-work> (raw)
In-Reply-To: <201011212101.14895.benscott@nwlink.com>

On Sun, 2010-11-21 at 21:01 -0800, ben wrote:
> If a volume group is clustered and the cluster is not running, lvm_vg_open() 
> fails and prints a message about skipping the group. However, lvm_errno() and 
> lvm_errmsg() are not updated. It would be really useful (to me) if the error 
> number was set to something specific to the clustering issue rather than a 
> generic error. 
> 

Thanks for reporting.  I see the code in question and will work on
updating the error codes and messages.

> Also, where are the errors defined or are only the standard system ones being 
> used?
> 

We are using errno codes and trying not to define LVM-specific codes.
The idea was to divide up lvm operations into small enough pieces and
re-use errno codes.


> Thank you and keep up the good work.
> 
> 

thank you for the feedback.

      reply	other threads:[~2010-11-23  4:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-22  5:01 [linux-lvm] Bug in error code for lvm_vg_open() ben
2010-11-23  4:03 ` Dave Wysochanski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1290484995.31336.1.camel@f12-work \
    --to=dwysocha@redhat.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).