linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
* [linux-lvm] Bug in error code for  lvm_vg_open()
@ 2010-11-22  5:01 ben
  2010-11-23  4:03 ` Dave Wysochanski
  0 siblings, 1 reply; 2+ messages in thread
From: ben @ 2010-11-22  5:01 UTC (permalink / raw)
  To: linux-lvm

If a volume group is clustered and the cluster is not running, lvm_vg_open() 
fails and prints a message about skipping the group. However, lvm_errno() and 
lvm_errmsg() are not updated. It would be really useful (to me) if the error 
number was set to something specific to the clustering issue rather than a 
generic error. 

Also, where are the errors defined or are only the standard system ones being 
used?

Thank you and keep up the good work.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [linux-lvm] Bug in error code for  lvm_vg_open()
  2010-11-22  5:01 [linux-lvm] Bug in error code for lvm_vg_open() ben
@ 2010-11-23  4:03 ` Dave Wysochanski
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Wysochanski @ 2010-11-23  4:03 UTC (permalink / raw)
  To: LVM general discussion and development

On Sun, 2010-11-21 at 21:01 -0800, ben wrote:
> If a volume group is clustered and the cluster is not running, lvm_vg_open() 
> fails and prints a message about skipping the group. However, lvm_errno() and 
> lvm_errmsg() are not updated. It would be really useful (to me) if the error 
> number was set to something specific to the clustering issue rather than a 
> generic error. 
> 

Thanks for reporting.  I see the code in question and will work on
updating the error codes and messages.

> Also, where are the errors defined or are only the standard system ones being 
> used?
> 

We are using errno codes and trying not to define LVM-specific codes.
The idea was to divide up lvm operations into small enough pieces and
re-use errno codes.


> Thank you and keep up the good work.
> 
> 

thank you for the feedback.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-11-23  4:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-22  5:01 [linux-lvm] Bug in error code for lvm_vg_open() ben
2010-11-23  4:03 ` Dave Wysochanski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).