From: Lukas Czerner <lczerner@redhat.com>
To: zkabelac@redhat.com
Cc: Lukas Czerner <lczerner@redhat.com>,
dchinner@redhat.com, rwheeler@redhat.com, linux-lvm@redhat.com
Subject: [linux-lvm] [PATCH 01/35] fsadm: Add "create" command
Date: Wed, 21 Sep 2011 18:45:20 +0200 [thread overview]
Message-ID: <1316623554-28975-2-git-send-email-lczerner@redhat.com> (raw)
In-Reply-To: <1316623554-28975-1-git-send-email-lczerner@redhat.com>
Create command provides the functionality of creating a new logical
volumes including defined file system.
This commit also changes the way how are commands recognised an
executed. The new approach is more suitable for bigger number of
commands.
Signed-off-by: Lukas Czerner <lczerner@redhat.com>
---
scripts/fsadm.sh | 140 ++++++++++++++++++++++++++++++++++++++++++++++++++----
1 files changed, 131 insertions(+), 9 deletions(-)
diff --git a/scripts/fsadm.sh b/scripts/fsadm.sh
index c8cc5e0..42c7da4 100755
--- a/scripts/fsadm.sh
+++ b/scripts/fsadm.sh
@@ -29,7 +29,7 @@
# 2 break detected
# 3 unsupported online filesystem check for given mounted fs
-TOOL=fsadm
+TOOL=$(basename $0)
_SAVEPATH=$PATH
PATH=/sbin:/usr/sbin:/bin:/usr/sbin:$PATH
@@ -76,6 +76,8 @@ REMOUNT=
PROCMOUNTS="/proc/mounts"
NULL="$DM_DEV_DIR/null"
+MAX_VGS=999
+
IFS_OLD=$IFS
# without bash $'\n'
NL='
@@ -122,6 +124,14 @@ dry() {
fi
verbose "Executing $@"
$@
+ if [ $? -ne 0 ]; then
+ error "FAILED. Exitting!"
+ fi
+}
+
+is_natural() {
+ test "$1" -ge 0 &> /dev/null && return 1
+ return 0
}
cleanup() {
@@ -365,12 +375,42 @@ resize_xfs() {
fi
}
+make_ext() {
+ device=$1
+ fstyp=$2
+ stripe=$3
+ stripesize=$4
+ bsize=4
+
+ if [ "$YES" ]; then
+ force="-F"
+ fi
+ stride=$(($stripesize/$bsize))
+ stripewidth=$(($stride*$stripe))
+
+ dry mkfs.$fstyp $force -b$(($bsize*1024)) -E stride=${stride},stripe-width=${stripewidth} $device
+}
+
+generic_make_fs() {
+ device=$1
+ fstyp=$2
+ bsize=4096
+
+ if [ "$YES" ]; then
+ force="-f"
+ fi
+
+ dry mkfs.$fstyp $force $device
+}
+
####################
# Resize filesystem
####################
resize() {
NEWSIZE=$2
detect_fs "$1"
+ is_natural $NEWSIZE
+ [ $? -ne 1 ] && error "$NEWSIZE is not valid number for file system size"
detect_device_size
verbose "Device \"$VOLUME\" size is $DEVSIZE bytes"
# if the size parameter is missing use device size
@@ -386,6 +426,89 @@ resize() {
cleanup 0
}
+name_exists() {
+ cmd=$1
+ search=$2
+ $LVM $cmd --separator ' ' 2>&1 | tail -n-1 | cut -d' ' -f3 | grep $search 2>&1> /dev/null
+ if [ $? -eq 0 ]; then
+ return 1
+ fi
+ return 0
+}
+
+#############################
+# Create a new logical volume
+#############################
+create() {
+ size="-l 100%FREE"
+ devcount=0
+
+ for i in $@; do
+ if [ -b $i ]; then
+ devices="$devices $i"
+ devcount=$(($devcount+1))
+ continue
+ fi
+ case $i in
+ "stripesize"* | "chunksize"*) stripesize=${i##*=} ;;
+ "name"*) name="--name ${i##*=}" ;;
+ "fstyp"*) fstyp=${i##*=} ;;
+ "size"*) size="-L ${i##*=}" ;;
+ *) error "Wrong option $i. (see: $TOOL --help)"
+ esac
+ done
+
+ for i in $(seq -w $MAX_VGS); do
+ name_exists vgs vg${i}
+ if [ $? -eq 0 ]; then
+ vgname="vg${i}"
+ break;
+ fi
+ done
+
+ [ -z "$vgname" ] && error "No suitable name for volume group found."
+ [ $devcount -eq 0 ] && error "No suitable device specified."
+
+ if [ "$stripesize" ]; then
+ striped="-i $devcount -I $stripesize"
+ fi
+
+ if [ "$name" ]; then
+ lvname="--name $name"
+ else
+ for i in $(seq -w $MAX_VGS); do
+ name_exists "vgs $vgname" lvol${i}
+ if [ $? -eq 0 ]; then
+ name="lvol${i}"
+ lvname="--name $name"
+ break;
+ fi
+ done
+ fi
+
+ dry $LVM vgcreate $VERB $vgname $devices
+ dry $LVM lvcreate $VERB $lvname $size $striped $vgname
+ device="/dev/${vgname}/${name}"
+
+ guess=0
+ echo "$fstyp"
+ if [ -z $fstyp ]; then
+ fstyp=$(echo $TOOL | sed 's/^.*\.//g')
+ guess=1
+ fi
+
+ case $fstyp in
+ ext[234]) make_ext $device $fstyp $devcount $stripesize ;;
+ xfs|reiserfs) generic_make_fs $device $fstyp;;
+ *) if [ $guess -eq 1 ]; then
+ return 0
+ else
+ error "Filesystem $fstyp is not supported"
+ fi
+ ;;
+ esac
+}
+
####################################
# Calclulate diff between two dates
# LANG=C input is expected the
@@ -477,18 +600,17 @@ do
"-e"|"--ext-offline") EXTOFF=1 ;;
"-y"|"--yes") YES="-y" ;;
"-l"|"--lvresize") DO_LVRESIZE=1 ;;
- "check") CHECK="$2" ; shift ;;
- "resize") RESIZE="$2"; NEWSIZE="$3" ; shift 2 ;;
+ "check") COMMAND=$1; shift; ARGS=$@; break ;;
+ "resize") COMMAND=$1; shift; ARGS=$@; break ;;
+ "create") COMMAND=$1; shift; ARGS=$@; break ;;
*) error "Wrong argument \"$1\". (see: $TOOL --help)"
esac
shift
done
-if [ -n "$CHECK" ]; then
- check "$CHECK"
-elif [ -n "$RESIZE" ]; then
- export FSADM_RUNNING="fsadm"
- resize "$RESIZE" "$NEWSIZE"
-else
+if [ -z $COMMAND ]; then
error "Missing command. (see: $TOOL --help)"
fi
+
+export FSADM_RUNNING="fsadm"
+$COMMAND $ARGS
--
1.7.4.4
next prev parent reply other threads:[~2011-09-21 16:45 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-21 16:45 [linux-lvm] [RFC][PATCH 00/35] fsadm update Lukas Czerner
2011-09-21 16:45 ` Lukas Czerner [this message]
2011-09-21 19:00 ` [linux-lvm] [PATCH 01/35] fsadm: Add "create" command Stephane Chazelas
2011-09-22 9:28 ` Lukas Czerner
2011-09-22 10:01 ` Zdenek Kabelac
2011-09-22 10:27 ` Lukas Czerner
2011-09-22 10:56 ` Stephane Chazelas
2011-09-21 16:45 ` [linux-lvm] [PATCH 02/35] fsadm: Add "destroy" command Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 03/35] fsadm: Add "list" command Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 04/35] fsadm: Make "create" command more vg aware Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 05/35] fsadm: Teach "destroy" command to take more arguments Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 06/35] fsadm: Simple cleanup and comment update Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 07/35] fsadm: Create "add" command Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 08/35] fsadm: Update "list" command for better alignment Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 09/35] fsadm: Specify number of stripes when no device is given Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 10/35] fsadm: Print type of the volume in filesystem listing Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 11/35] fsadm: Add "remove" command Lukas Czerner
2011-09-22 10:06 ` Zdenek Kabelac
2011-09-22 10:36 ` Lukas Czerner
2011-09-22 10:43 ` Zdenek Kabelac
2011-09-22 10:52 ` Lukas Czerner
2011-09-22 11:41 ` Zdenek Kabelac
2011-09-21 16:45 ` [linux-lvm] [PATCH 12/35] fsadm: Try to avoid calling LVM in the loops Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 13/35] fsadm: Merge "destroy" and "remove" into one command Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 14/35] fsadm: Allow to remove all volume groups Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 15/35] fsadm: Make all internal math in kilobytes Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 16/35] fsadm: Use warn for warnings in list command Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 17/35] fsadm: Handle resize if there is no file system Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 18/35] fsadm: Fsck extN before resize only if it is not mounted Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 19/35] fsadm: Align numbers to the decimal point Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 20/35] fsadm: Add simple configuration file Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 21/35] fsadm: Use DEFAULT_POOL when creating volume group Lukas Czerner
2011-09-22 10:09 ` Zdenek Kabelac
2011-09-21 16:45 ` [linux-lvm] [PATCH 22/35] fsadm: Add LVOL_PREFIX configuration option Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 23/35] fsadm: Only use readlink if link is provided Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 24/35] fsadm: Remove unnecessary modification of PATH variable Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 25/35] fsadm: Allow to specify size without "size=" prefix in "resize" Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 26/35] fsadm: Allow to specify lv in vg/lv format Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 27/35] fsadm: error out when no size is provided in resize Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 28/35] fsadm: Umount ext2 file system prior resize Lukas Czerner
2011-09-22 10:28 ` Zdenek Kabelac
2011-09-21 16:45 ` [linux-lvm] [PATCH 29/35] lvresize: Specify --resize-fs-only when going to use fsadm resize Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 30/35] test: add helper to compute aligned lv size Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 31/35] fsadm: Add help for new commands and update man page Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 32/35] fsadm: Update authorship of the fsadm Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 33/35] test: Add test for fsadm add command Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 34/35] test: Add test for fsadm create command Lukas Czerner
2011-09-21 16:45 ` [linux-lvm] [PATCH 35/35] test: Add test for fsadm resize command Lukas Czerner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316623554-28975-2-git-send-email-lczerner@redhat.com \
--to=lczerner@redhat.com \
--cc=dchinner@redhat.com \
--cc=linux-lvm@redhat.com \
--cc=rwheeler@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).