linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: "Xinwei Hu" <hxinwei@gmail.com>
To: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] Re: Patch to clvmd-openais.c again
Date: Tue, 29 Apr 2008 00:27:56 +0800	[thread overview]
Message-ID: <1cafab770804280927u69a71c26n7a6857f958efd020@mail.gmail.com> (raw)
In-Reply-To: <4815918E.5080806@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

> Your patch has now been included in upstream clvmd.

Thanks for the inclusion.

And here are another 2:
. remove_lock_wait.diff remove the definition of "struct lock_wait",
which is not used since the switch away from async version saLck
. num_nodes should equal to member_list_entries, i.e.
joined_list_entires is 0 when a node leaves the group.

Would you help review them ;)

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: remove_lock_wait.diff --]
[-- Type: text/x-patch; name=remove_lock_wait.diff, Size: 391 bytes --]

--- clvmd-openais.c.orig	2008-04-28 21:53:46.000000000 +0800
+++ clvmd-openais.c	2008-04-28 21:53:53.000000000 +0800
@@ -100,13 +100,6 @@
 	SaNameT              lock_name;
 };
 
-struct lock_wait
-{
-	pthread_cond_t cond;
-	pthread_mutex_t mutex;
-	int status;
-};
-
 /* Set errno to something approximating the right value and return 0 or -1 */
 static int ais_to_errno(SaAisErrorT err)
 {

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #3: num_nodes_fix.diff --]
[-- Type: text/x-patch; name=num_nodes_fix.diff, Size: 322 bytes --]

--- clvmd-openais.c.orig	2008-04-28 21:53:53.000000000 +0800
+++ clvmd-openais.c	2008-04-28 22:03:05.000000000 +0800
@@ -306,7 +306,7 @@
 		ninfo->state = NODE_CLVMD;
 	}
 
-	num_nodes = joined_list_entries;
+	num_nodes = member_list_entries;
 }
 
 static int lck_dispatch(struct local_client *client, char *buf, int len,

  reply	other threads:[~2008-04-28 16:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-25 10:11 [linux-lvm] Patch to clvmd-openais.c again Xinwei Hu
2008-04-25 10:12 ` [linux-lvm] " Xinwei Hu
2008-04-28  8:57   ` Christine Caulfield
2008-04-28 16:27     ` Xinwei Hu [this message]
2008-04-29  8:55       ` Christine Caulfield

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1cafab770804280927u69a71c26n7a6857f958efd020@mail.gmail.com \
    --to=hxinwei@gmail.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).