[linux-lvm] 2.4.3-ac{6,7} LVM hang

[linux-lvm] 2.4.3-ac{6,7} LVM hang

[Rik van Riel]

Hi,

2.4.3-ac4 seems to work great on my test box (UP K6-2 with SCSI
disk), but 2.4.3-ac6 and 2.4.3-ac7 hang pretty hard when I try
to access any of the logical volumes on my test box.

The following changelog entry in Linus' changelog suggests me
whom to bother:   ;)
 - Jens Axboe: LVM and loop fixes

regards,

Rik
--
Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...

		http://www.surriel.com/
http://www.conectiva.com/	http://distro.conectiva.com.br/

Re: [linux-lvm] 2.4.3-ac{6,7} LVM hang

[Arjan Filius]

Hello,

Same here as reported.
restoring lvm.c from 2.4.3 into 2.4.4-pre? "fixes" this. (tested not ac's
kernel)

Greatings,

On Mon, 16 Apr 2001, Rik van Riel wrote:

> Hi,
>
> 2.4.3-ac4 seems to work great on my test box (UP K6-2 with SCSI
> disk), but 2.4.3-ac6 and 2.4.3-ac7 hang pretty hard when I try
> to access any of the logical volumes on my test box.
>
> The following changelog entry in Linus' changelog suggests me
> whom to bother:   ;)
>  - Jens Axboe: LVM and loop fixes
>
> regards,
>
> Rik
> --
> Virtual memory is like a game you can't win;
> However, without VM there's truly nothing to lose...
>
> 		http://www.surriel.com/
> http://www.conectiva.com/	http://distro.conectiva.com.br/
>
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
>

-- 
Arjan Filius
mailto:iafilius@xs4all.nl

Re: [linux-lvm] 2.4.3-ac{6,7} LVM hang

[Jens Axboe]

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

On Thu, Apr 19 2001, Arjan Filius wrote:
> Hello,
> 
> Same here as reported.
> restoring lvm.c from 2.4.3 into 2.4.4-pre? "fixes" this. (tested not ac's
> kernel)

Does attached patch fix it?

-- 
Jens Axboe


[-- Attachment #2: lvm-244p4-1 --]
[-- Type: text/plain, Size: 369 bytes --]

--- /opt/kernel/linux-2.4.4-pre4/drivers/md/lvm.c	Wed Apr 18 14:37:34 2001
+++ drivers/md/lvm.c	Thu Apr 19 23:40:39 2001
@@ -1674,10 +1674,11 @@
 			       int rw,
 			       struct buffer_head *bh)
 {
-	int ret = lvm_map(bh, rw);
-	if (ret < 0)
-		buffer_IO_error(bh);
-	return ret;
+	if (lvm_map(bh, rw) >= 0)
+		return 1;
+
+	buffer_IO_error(bh);
+	return 0;
 }
 
 

Re: [linux-lvm] 2.4.3-ac{6,7} LVM hang

[Ulrich Drepper]

Jens Axboe <axboe@suse.de> writes:

> Does attached patch fix it?

Yes.

-- 
---------------.                          ,-.   1325 Chesapeake Terrace
Ulrich Drepper  \    ,-------------------'   \  Sunnyvale, CA 94089 USA
Red Hat          `--' drepper at redhat.com   `------------------------

Re: [linux-lvm] 2.4.3-ac{6,7} LVM hang

[Rik van Riel]

On 19 Apr 2001, Ulrich Drepper wrote:
> Jens Axboe <axboe@suse.de> writes:
> 
> > Does attached patch fix it?
> 
> Yes.

Jens, I guess we should submit these patches to Alan and Linus
now. This way we'll get a working LVM again.

Waiting for the next official LVM release (and the next set of
bugs) doesn't seem like a very productive way to me ;)

regards,

Rik
--
Virtual memory is like a game you can't win;
However, without VM there's truly nothing to lose...

		http://www.surriel.com/
http://www.conectiva.com/	http://distro.conectiva.com.br/

Re: [linux-lvm] 2.4.3-ac{6,7} LVM hang

[Luca Berra]

On Mon, Apr 16, 2001 at 04:55:15PM -0300, Rik van Riel wrote:
> Hi,
> 
> 2.4.3-ac4 seems to work great on my test box (UP K6-2 with SCSI
> disk), but 2.4.3-ac6 and 2.4.3-ac7 hang pretty hard when I try
> to access any of the logical volumes on my test box.
> 
sorry i am a bit late on ac releases (ac3 at the moment)
does ac6/7 include lvm 0.9.1beta7, does the problem happen
with stock kernel lvm, wich was b2 afaik, or with lvm patches applied?
in the former case, why bother? b2 is broken anyway.

L.

-- 
Luca Berra -- bluca@comedia.it
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \

Re: [linux-lvm] 2.4.3-ac{6,7} LVM hang

[Arjan Filius]

Hello Jens,

Yes this fixes it.

I'm running 2.4.4-pre4 with only your patch applied.

Greatings,


On Thu, 19 Apr 2001, Jens Axboe wrote:

> On Thu, Apr 19 2001, Arjan Filius wrote:
> > Hello,
> >
> > Same here as reported.
> > restoring lvm.c from 2.4.3 into 2.4.4-pre? "fixes" this. (tested not ac's
> > kernel)
>
> Does attached patch fix it?
>
>

-- 
Arjan Filius
mailto:iafilius@xs4all.nl

Re: [linux-lvm] 2.4.3-ac{6,7} LVM hang

[Jens Axboe]

On Thu, Apr 19 2001, Rik van Riel wrote:
> On 19 Apr 2001, Ulrich Drepper wrote:
> > Jens Axboe <axboe@suse.de> writes:
> > 
> > > Does attached patch fix it?
> > 
> > Yes.
> 
> Jens, I guess we should submit these patches to Alan and Linus
> now. This way we'll get a working LVM again.

Already done

-- 
Jens Axboe