Re: [linux-lvm] A Caldera related bug?

[Christoph Hellwig <hch@ns.caldera.de>]

On Thu, Aug 30, 2001 at 04:03:48PM +0100, Joe Thornber wrote:
> On Thu, Aug 30, 2001 at 02:16:31PM +0200, Christoph Hellwig wrote:
> > On Thu, Aug 30, 2001 at 12:09:29PM +0100, Joe Thornber wrote:
> > > On Thu, Aug 30, 2001 at 11:46:13AM +0200, Christoph Hellwig wrote:
> > > > On Thu, Aug 30, 2001 at 03:23:21AM -0600, Andreas Dilger wrote:
> > > > > In the end, what is really needed is a well-defined LVM API between
> > > > > kernel and user-space that doesn't pass this kind of stuff.
> > > > 
> > > > Completly agreed.
> > > 
> > > I think every one is aware of this, but we can't change the interface during
> > > the 2.4 series.
> > 
> > Well, you change it all over the time..
> > IMHO replacing all these kernel types in the structures also used by the
> > tools to others that have the same size but do not depend on kernel headers
> > would be a very good thing for 1.0.2.
> 
> ok, I'll look at them.  I can't see how we can get rid of the kdev_t's
> though.

#ifdef __KERNEL__
#include <linux/kdev_t.h>
typedef kdev_t lvm_dev_t;
#else
typedef uint16_t lvm_dev_t;
#endif

and s/kdev_t/lvm_dev_t/g in lvm.h.

	Christoph

-- 
Of course it doesn't work. We've performed a software upgrade.