Re: [linux-lvm] 1.0.1-rc2 config & kernel question

[AJ Lewis <lewis@sistina.com>]

[-- Attachment #1: Type: text/plain, Size: 3831 bytes --]

On Thu, Sep 20, 2001 at 03:51:57PM +0100, James Pattinson wrote:
> I've just downloaded LVM 1.0.1-rc2 and tried to configure it ready for kernel
> 2.4.9. However I get this output:
> 
> [root@fuse 1.0.1-rc2]# ./configure 
> .
> . (omitted)
> .
> checking for st_rdev in struct stat... (cached) yes
> checking whether time.h and sys/time.h may both be included... (cached) yes
> ./scripts/linuxver: [: ==: binary operator expected
> ./configure: [: ==: binary operator expected
> checking whether gcc needs -traditional... (cached) no
> checking return type of signal handlers... (cached) int
> checking for vprintf... (cached) yes
> checking for mkdir... (cached) yes
> checking for rmdir... (cached) yes
> checking for uname... (cached) yes
> creating ./config.status
> creating Makefile
> creating make.tmpl
> creating PATCHES/Makefile
> creating tools/Makefile
> creating tools/tools_and_lib.make.tmpl
> creating tools/lib/Makefile
> creating tools/man8/Makefile
> ./configure: ${srcdir/#\/*}: bad substitution
> 
> The patch seems to build OK however.

The following patch fixes that issue with configure.  I was
using an up-to-date version of bash when i wrote those in
originally, and older versions don't like the operators i used.
The following patch should fix the problem:

Index: configure.in
===================================================================
RCS file: /var/cvs/LVM/configure.in,v
retrieving revision 1.6
retrieving revision 1.7
diff -u -b -B -u -r1.6 -r1.7
--- configure.in	2001/08/23 19:34:14	1.6
+++ configure.in	2001/09/06 13:02:34	1.7
@@ -75,7 +75,7 @@
 fi
 dnl -- get the version of the specified kernel
 kernel_ver=`$srcdir/scripts/linuxver -d $kernel_dir`;
-if [[ "x${kernel_ver}" == "x" ]]; then
+if [[ "x${kernel_ver}" = "x" ]]; then
  	echo -n "*** Unable to determine version of linux to build "
 	echo "patches for ***";
  	echo -n "*** Consider using the --with-kernel_dir flag     "
@@ -131,7 +131,8 @@
 tools/lib/Makefile							\
 tools/man8/Makefile							\
 )
-test=${srcdir/#\/*}
+# if there's a leading '/', assign test the null string...
+test=`echo ${srcdir} | sed -e '/^\/.*/d'`
 if [[ -z $test ]] ; then
 ln -sf $srcdir/kernel/lvm.h tools/lib/lvm.h;
 else
Index: configure
===================================================================
RCS file: /var/cvs/LVM/configure,v
retrieving revision 1.8
retrieving revision 1.9
diff -u -b -B -u -r1.8 -r1.9
--- configure	2001/08/23 19:34:14	1.8
+++ configure	2001/09/06 13:02:34	1.9
@@ -1594,7 +1594,7 @@
 	kernel_dir=${topobjdir}/${kernel_dir};
 fi
 kernel_ver=`$srcdir/scripts/linuxver -d $kernel_dir`;
-if [ "x${kernel_ver}" == "x" ]; then
+if [ "x${kernel_ver}" = "x" ]; then
  	echo -n "*** Unable to determine version of linux to build "
 	echo "patches for ***";
  	echo -n "*** Consider using the --with-kernel_dir flag     "
@@ -2184,7 +2184,8 @@
 rm -fr confdefs* $ac_clean_files
 test "$no_create" = yes || ${CONFIG_SHELL-/bin/sh} $CONFIG_STATUS || exit 1
 
-test=${srcdir/#\/*}
+# if there's a leading '/', assign test the null string...
+test=`echo ${srcdir} | sed -e '/^\/.*/d'`
 if [ -z $test ] ; then
 ln -sf $srcdir/kernel/lvm.h tools/lib/lvm.h;
 else

Regards,
-- 
AJ Lewis
Sistina Software Inc.                  Voice:  612-638-0500
1313 5th St SE, Suite 111              Fax:    612-638-0500
Minneapolis, MN 55414                  E-Mail: lewis@sistina.com
http://www.sistina.com

Current GPG fingerprint = 60F3 160D C0D5 2C4B 751B  4FF9 6F67 E9BC 44CD DE95

-----Begin Obligatory Humorous Quote----------------------------------------
Quitters never win, and winners never quit,
but those who never quit AND never win are idiots.
-----End Obligatory Humorous Quote------------------------------------------

[-- Attachment #2: Type: application/pgp-signature, Size: 232 bytes --]