[linux-lvm] Re: linux2.4.10/lvm1.0.1rc3 does not compile

[linux-lvm] Re: linux2.4.10/lvm1.0.1rc3 does not compile

[Aman Shahi]

If I am not mistaken. the function 
static void __upadte_hardsectsize(lv_t *lv) 
has been declared and called as it is in lvm.c. But in
the definition it has been written as 
static void __update_hardblocksize(lv_t *lv)

so changing __update_hardblocksize(lv_t *lv)
in ~/LVM/1.0.1-rc3/kernel/lvm.c and
~linux-2.4.10/drivers/md/lvm.c 
to  __update_hardsectsize(lv_t *lv)
should resolve this compilation problem.

regards,
Aman Shahi.

>LVM 1.0.1rc3 does not compile (link) with Linux
2.4.10 >on my system.

>Does anyone know what went wrong?
>Regards, Markus



__________________________________________________
Do You Yahoo!?
Listen to your Yahoo! Mail messages from any phone.
http://phone.yahoo.com

Re: [linux-lvm] Re: linux2.4.10/lvm1.0.1rc3 does not compile

[Markus Dobel]

On Tue, Oct 02, 2001 at 01:07:22PM -0700, Aman Shahi wrote:
> 
> so changing __update_hardblocksize(lv_t *lv)
> in ~/LVM/1.0.1-rc3/kernel/lvm.c and
> ~linux-2.4.10/drivers/md/lvm.c 
> to  __update_hardsectsize(lv_t *lv)
> should resolve this compilation problem.

Thanks, that did the trick for me. 

After that vgscan did not find any Volume Groups in 2.4.10, while it
did in 2.4.7 (with LVM 1.0). Interesting: using "vgrename" on 2.4.7
helped here at last (After trying lots of other non-destructive changes
to the VG/underlying PVs) . I just renamed the Group vg1 to vg0 and now
vgscan detects it on 2.4.10, too.

This incident leaves a bitter taste somehow...

Regards, Markus

Re: [linux-lvm] Re: linux2.4.10/lvm1.0.1rc3 does not compile

[Andreas Dilger]

On Oct 02, 2001  13:07 -0700, Aman Shahi wrote:
> If I am not mistaken. the function 
> static void __upadte_hardsectsize(lv_t *lv) 
> has been declared and called as it is in lvm.c. But in
> the definition it has been written as 
> static void __update_hardblocksize(lv_t *lv)
> 
> so changing __update_hardblocksize(lv_t *lv)
> in ~/LVM/1.0.1-rc3/kernel/lvm.c and
> ~linux-2.4.10/drivers/md/lvm.c 
> to  __update_hardsectsize(lv_t *lv)
> should resolve this compilation problem.

Yes, this is my fault.  I was moving over some minor changes from my
other LVM tree and trying to generate a patch for Linus, but I must
have made a mistake in search & replace of variable names hitting this
function name as well.  Ah, the joys of having so many LVM source trees
to work with.

I've fixed the CVS, if someone wants to make a new -rc4 release quickly.

Cheers, Andreas
--
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert