Linux LVM users
 help / color / mirror / Atom feed
From: Andreas Dilger <adilger@turbolabs.com>
To: linux-lvm@sistina.com
Subject: Re: [linux-lvm] pvcreate fails on a software RAID metadisk
Date: Thu, 4 Oct 2001 14:46:43 -0600	[thread overview]
Message-ID: <20011004144643.B31725@turbolinux.com> (raw)
In-Reply-To: <3BBCBF87.5520C8F9@legis.state.ak.us>

On Oct 04, 2001  11:59 -0800, Bill Ellis wrote:
> Some more playing around led me to discover that 'lvmdiskscan' is also not
> recognizing my software RAID metadisks correctly.  Here's what I think are the
> relevant portions of the ~5600 lines of output from the 'lvmdiskscan -d -v'
> command:
> 
> <22> lvm_dir_cache_find -- CALLED with /dev/md7
> <333> pv_check_name -- CALLED with "/dev/md7"
> <4444> lvm_check_chars -- CALLED with name: "/dev/md7"
> <4444> lvm_check_chars -- LEAVING with ret: 0
> <4444> lvm_check_dev -- CALLED
> <55555> lvm_check_partitioned_dev -- CALLED
> <666666> lvm_get_device_type called
> <666666> lvm_get_device_type leaving with 2
> <55555> lvm_check_partitioned_dev -- LEAVING with ret: TRUE

This is a problem - MD devices are not partitioned.  Have a look at
this function to see why it thinks so.

> <4444> lvm_check_dev -- LEAVING with ret: 1
> <333> pv_check_name -- LEAVING with ret: 0
> <333> lvm_dir_cache -- CALLED
> <333> lvm_dir_cache -- LEAVING with ret: 50
> <22> lvm_dir_cache_find -- LEAVING with entry: 4

> <22> lvm_check_partitioned_dev -- CALLED
> <333> lvm_get_device_type called
> <333> lvm_get_device_type leaving with 2
> <22> lvm_check_partitioned_dev -- LEAVING with ret: TRUE

A pet peeve of mine - we shouldn't have to call this function twice
(probably we should assume that anything that is in the dir cache is
a valid device (and check devices one time when they are added)).

> <22> lvm_partition_count -- CALLED for 0x907
> <333> lvm_get_device_type called
> <333> lvm_get_device_type leaving with 2
> <22> lvm_partition_count -- LEAVING with ret: 16

I suspect this is just an artifact of the code thinking it is a partitioned
device.

Cheers, Andreas
--
Andreas Dilger  \ "If a man ate a pound of pasta and a pound of antipasto,
                 \  would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/               -- Dogbert

  reply	other threads:[~2001-10-04 20:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-04 16:16 [linux-lvm] pvcreate fails on a software RAID metadisk Bill Ellis
2001-10-04 19:59 ` Bill Ellis
2001-10-04 20:46   ` Andreas Dilger [this message]
2001-10-05  8:30     ` Luca Berra
2001-10-05  9:31       ` Andreas Dilger
2001-10-05  9:13 ` yves.alloyer
2001-10-05 19:31   ` Luca Berra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20011004144643.B31725@turbolinux.com \
    --to=adilger@turbolabs.com \
    --cc=linux-lvm@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox