From: Christoph Hellwig <hch@ns.caldera.de>
To: linux-lvm@sistina.com
Subject: Re: [linux-lvm] Removing direct access to gendisk_head
Date: Sun, 7 Oct 2001 12:02:26 +0200 [thread overview]
Message-ID: <20011007120226.A15080@caldera.de> (raw)
In-Reply-To: <20011006130147.C31614@lug-owl.de>; from jbglaw@lug-owl.de on Sat, Oct 06, 2001 at 01:01:47PM +0200
On Sat, Oct 06, 2001 at 01:01:47PM +0200, Jan-Benedict Glaw wrote:
> Hi!
>
> I'm currently looking over kernel code (for cleaning-up purposes)
> and removed EXPORT_SYMBOL(gendisk_head) which was a no-no for
> current LVM kernel code. Please think about picking up this patch
>
> - Named struct initializers
> - Removing direct use of gendisk_head
>
> There's an open Q: Do we need to nullify ->real_devices and ->next?
> I don't think so (but I am unsure) so please remove these two lines
> upon your oppinion:-)
lvm_gendisk is in bss so it's ok to nullify it - see what I did to
the inkernel LVM :)
Christoph
--
Of course it doesn't work. We've performed a software upgrade.
prev parent reply other threads:[~2001-10-07 10:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-06 11:01 [linux-lvm] Removing direct access to gendisk_head Jan-Benedict Glaw
2001-10-07 10:02 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011007120226.A15080@caldera.de \
--to=hch@ns.caldera.de \
--cc=linux-lvm@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).