From: Andreas Dilger <adilger@turbolabs.com>
To: linux-lvm@sistina.com
Subject: Re: [linux-lvm] [PATCH] snapshots on unaligned lvs
Date: Thu, 11 Oct 2001 14:56:11 -0600 [thread overview]
Message-ID: <20011011145611.H8382@turbolinux.com> (raw)
In-Reply-To: <1383150000.1002824196@tiny>
On Oct 11, 2001 14:16 -0400, Chris Mason wrote:
> @@ -360,8 +361,14 @@
>
> iobuf = lv_snap->lv_iobuf;
>
> - blksize_org = lvm_get_blksize(org_phys_dev);
> - blksize_snap = lvm_get_blksize(snap_phys_dev);
> + blksize_org = get_hardsect_size(org_phys_dev);
> + blksize_snap = get_hardsect_size(snap_phys_dev);
FYI - there is now a helper function "lvm_sectsize()" which is defined
appropriately for a given kernel version to call get_hardsect_size()
or get_hardblock_size(). I originally put it directly in lvm.c because
that was the only place we used it, but it should move to lvm-internal.h
instead.
I won't check in this patch until I at least hear some Yea's as I can't
do any testing on it myself right now. Of course the Sistina folks are
free to test/commit it as well.
Cheers, Andreas
--
Andreas Dilger \ "If a man ate a pound of pasta and a pound of antipasto,
\ would they cancel out, leaving him still hungry?"
http://www-mddsp.enel.ucalgary.ca/People/adilger/ -- Dogbert
prev parent reply other threads:[~2001-10-11 20:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-10-11 18:16 [linux-lvm] [PATCH] snapshots on unaligned lvs Chris Mason
2001-10-11 20:56 ` Andreas Dilger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20011011145611.H8382@turbolinux.com \
--to=adilger@turbolabs.com \
--cc=linux-lvm@sistina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).