From: Christoph Hellwig <hch@caldera.de>
To: linux-lvm@sistina.com
Cc: Alexander Viro <viro@math.psu.edu>, linux-kernel@vger.kernel.org
Subject: Re: [linux-lvm] Re: [RFLART] kdev_t in ioctls
Date: Mon Jan 14 12:09:01 2002 [thread overview]
Message-ID: <20020114190834.A3473@caldera.de> (raw)
In-Reply-To: <Pine.LNX.4.33.0201140957040.15128-100000@penguin.transmeta.com>; from torvalds@transmeta.com on Mon, Jan 14, 2002 at 10:01:25AM -0800
On Mon, Jan 14, 2002 at 10:01:25AM -0800, Linus Torvalds wrote:
>
> On Mon, 14 Jan 2002, Alexander Viro wrote:
> >
> > Linus, at least some ioctls (e.g. lvm ones) pass kdev_t from/to
> > userland. While the common policy with ioctls is "anything goes", this
> > kind of abuse is IMNSHO over the top.
>
> That's completely bogus.
>
> The good news is that the bit-for-bit representation of old kdev_t and
> "dev_t" are obviously 100% the same, so we should just make the damn thing
> be dev_t, and user land will never notice anything.
Glibc disagrees with you (bits/types.h):
typedef __u_quad_t __dev_t; /* Type of device numbers. */
We'd have to use __kernel_dev_t instead which again pulls kernel
headers in..
Christoph
next prev parent reply other threads:[~2002-01-14 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.GSO.4.21.0201141227260.224-100000@weyl.math.psu.edu>
2002-01-14 12:04 ` [linux-lvm] Re: [RFLART] kdev_t in ioctls Linus Torvalds
2002-01-14 12:09 ` Christoph Hellwig [this message]
2002-01-14 12:14 ` Christoph Hellwig
2002-01-14 12:45 ` Alan Cox
2002-01-14 12:47 ` Christoph Hellwig
2002-01-14 12:53 ` Linus Torvalds
2002-01-14 12:21 ` Alexander Viro
2002-01-15 6:27 ` Joe Thornber
2002-01-15 14:46 Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20020114190834.A3473@caldera.de \
--to=hch@caldera.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-lvm@sistina.com \
--cc=viro@math.psu.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox