Linux LVM users
 help / color / mirror / Atom feed
From: "Heinz J . Mauelshagen" <mauelshagen@sistina.com>
To: linux-lvm@sistina.com
Subject: Re: [linux-lvm] Snapshot resizing memory leak
Date: Tue Mar  4 06:05:02 2003	[thread overview]
Message-ID: <20030304125855.B19923@sistina.com> (raw)
In-Reply-To: <3E63C91A.9030803@mac.com>; from dalestephenson@mac.com on Mon, Mar 03, 2003 at 01:28:58PM -0800

Dale,

thanks for finding this one.
Could you please give the LVM version you patched in future posts ?

Regards,
Heinz    -- The LVM Guy --

On Mon, Mar 03, 2003 at 01:28:58PM -0800, Dale J. Stephenson wrote:
> It looks like the current lvm code still has the memory leak when 
> resizing snapshots.  The lv_block_exception and lv_snapshot_hash_table 
> fields are set to ones newly allocated for the new size, but the old 
> ones are not freed.  The following patch should fix it:
> 
> --- linux/drivers/md/lvm.c.orig	Thu Mar 14 08:21:16 2002
> +++ linux/drivers/md/lvm.c	Thu Mar 14 08:23:07 2002
> @@ -2489,6 +2489,8 @@
>  		memcpy(new_lv->lv_block_exception,
>  		       old_lv->lv_block_exception, size);
>  
> +		vfree(old_lv->lv_block_exception);
> +		vfree(old_lv->lv_snapshot_hash_table);
>  		old_lv->lv_remap_end = new_lv->lv_remap_end;
>  		old_lv->lv_block_exception = new_lv->lv_block_exception;
>  		old_lv->lv_snapshot_hash_table =
> 
> 
> 
> 
> _______________________________________________
> linux-lvm mailing list
> linux-lvm@sistina.com
> http://lists.sistina.com/mailman/listinfo/linux-lvm
> read the LVM HOW-TO at http://tldp.org/HOWTO/LVM-HOWTO/

*** Software bugs are stupid.
    Nevertheless it needs not so stupid people to solve them ***

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

Heinz Mauelshagen                                 Sistina Software Inc.
Senior Consultant/Developer                       Am Sonnenhang 11
                                                  56242 Marienrachdorf
                                                  Germany
Mauelshagen@Sistina.com                           +49 2626 141200
                                                       FAX 924446
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-

      reply	other threads:[~2003-03-04  6:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-03-03 12:28 [linux-lvm] Snapshot resizing memory leak Dale J. Stephenson
2003-03-04  6:05 ` Heinz J . Mauelshagen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030304125855.B19923@sistina.com \
    --to=mauelshagen@sistina.com \
    --cc=linux-lvm@sistina.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox