From: Alasdair G Kergon <agk@redhat.com>
To: Jun'ichi Nomura <j-nomura@ce.jp.nec.com>
Cc: Alasdair Kergon <agk@redhat.com>, linux-lvm@redhat.com
Subject: [linux-lvm] Re: [PATCH LVM2] (3/3) add 'cling' allocation policy
Date: Sun, 8 Oct 2006 13:06:56 +0100 [thread overview]
Message-ID: <20061008120656.GE17654@agk.surrey.redhat.com> (raw)
In-Reply-To: <4526D126.2060004@ce.jp.nec.com>
On Fri, Oct 06, 2006 at 05:56:54PM -0400, Jun'ichi Nomura wrote:
> This patch adds 'cling' allocation policy.
Applied.
Needed to reset preferred_count at the top of the outer loop.
(Was no need previously as contiguous had exactly one possible
match so was pointless going round the loop again so it didn't.)
> + } else if (cling) {
> + if (prev_lvseg &&
> + _check_same_pv(prev_lvseg,
> + pva, areas,
> + areas_size)) {
> + prefered_count++;
> goto next_pv;
> }
> continue;
goto next_pv here - pointless repeatedly testing the same PV - if
it didn't match once it won't again
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2006-10-08 12:06 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 21:54 [linux-lvm] [PATCH LVM2] (0/3) 'cling' allocation policy Jun'ichi Nomura
2006-10-06 21:55 ` [linux-lvm] [PATCH LVM2] (1/3) remove unnecessary parameter from _check_contiguous Jun'ichi Nomura
2006-10-06 21:56 ` [linux-lvm] [PATCH LVM2] (2/3) use _for_each_pv() from _check_contiguous() Jun'ichi Nomura
2006-10-07 23:38 ` [linux-lvm] " Alasdair G Kergon
2006-10-09 16:27 ` Jun'ichi Nomura
2006-10-06 21:56 ` [linux-lvm] [PATCH LVM2] (3/3) add 'cling' allocation policy Jun'ichi Nomura
2006-10-08 12:06 ` Alasdair G Kergon [this message]
2006-10-07 10:51 ` [linux-lvm] Re: [PATCH LVM2] (0/3) " Alasdair G Kergon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061008120656.GE17654@agk.surrey.redhat.com \
--to=agk@redhat.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).