linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Alasdair G Kergon <agk@redhat.com>
To: Douglas Mayle <douglas@mayle.org>
Cc: Jeff Layton <jtlayton@poochiereds.net>, LVM <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] Update to lvm2create_initrd
Date: Tue, 14 Nov 2006 17:02:47 +0000	[thread overview]
Message-ID: <20061114170247.GD30653@agk.surrey.redhat.com> (raw)
In-Reply-To: <CA207AAA-711C-4AAD-911A-4301C61C165B@mayle.org>

On Sat, Nov 11, 2006 at 12:18:39PM +0100, Douglas Mayle wrote:
> I've made an update to the lvm2create_initrd script that fixes some  
> problems with ldd output that were never addressed in the first  
> version (e.g. libraries linked with a static path).
 
> I also check for binaries in the path, rather than hardcoding their  
> location, and I've added support for the Gentoo style of MAKEDEV.


Please update the changelog.

Can someone confirm the updated script also still works on Debian?


-BINFILES=${BINFILES:-"/lib/lvm-200/lvm /bin/bash /bin/busybox /sbin/pivot_root"}
+BINFILES=${BINFILES:-"`which lvm` `which bash` `which busybox` `which pivot_root`"}

Will 'which lvm' always give the same answer as before on Debian,
or, if not, does it matter?


-LIBFILES=`ldd $BINFILES 2>/dev/null | awk '{if (/=>/) { print $3 }}' | sort -u`
+LIBFILES=`ldd $BINFILES 2>/dev/null |grep -v linux-gate |grep -v : | awk '{if (/=>/) { print $3 } else if (/\//) { print $1 }}' | sort -u`

This needs a comment explaining what's going on (e.g. include sample 
output in the comment).  What's special about linux-gate?
And why not combine the two greps?  -E (linux-gate|:)

Alasdair
-- 
agk@redhat.com

  reply	other threads:[~2006-11-14 17:02 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-11-11 11:18 [linux-lvm] Update to lvm2create_initrd Douglas Mayle
2006-11-14 17:02 ` Alasdair G Kergon [this message]
2006-11-14 17:49   ` Douglas Mayle
2006-11-20 19:37     ` Douglas Mayle
2006-11-21 22:39       ` Alasdair G Kergon
2006-11-21 22:44         ` Alasdair G Kergon
2006-11-26 15:11           ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061114170247.GD30653@agk.surrey.redhat.com \
    --to=agk@redhat.com \
    --cc=douglas@mayle.org \
    --cc=jtlayton@poochiereds.net \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).