From: Alasdair G Kergon <agk@redhat.com>
To: Arkadiusz Miskiewicz <arekm@maven.pl>
Cc: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] [PATCH]: don't use functions marked by SUSv3 as legacy
Date: Sun, 1 Jul 2007 21:34:36 +0100 [thread overview]
Message-ID: <20070701203436.GK30047@agk.fab.redhat.com> (raw)
In-Reply-To: <200707011658.00819.arekm@maven.pl>
On Sun, Jul 01, 2007 at 04:58:00PM +0200, Arkadiusz Miskiewicz wrote:
> Please merge this one, too:
> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/lvm2-as-needed.patch
Yep.
> The other one puts LDFLAGS (linker flags) not CFLAGS (cflags is for
> compilation, ldflags for linking) and changes order so linking will success
> when using -Wl,--as-needed flag.
For fsadm, which I don't consider production-ready yet - but if you're
using it successfully that'd be nice to know!
> There are also others mostly self explaining patches for device-mapper:
> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-disable_dynamic_link.patch
Want to test that one - how does it handle configure --disable-dynamic without
--enable-static? (A nice error message? Is there a cleaner way?)
> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-force-local-headers.patch
Not sure what the best way to achieve that upstream is: the patch breaks some
valid alternative configurations.
> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-getopt.patch
OK
> http://cvs.pld-linux.org/cgi-bin/cvsweb/SOURCES/device-mapper-klibc.patch
basename: I'd rather call a local implementation if 'configure' didn't find one
fread+sscanf: I'd prefer not to change that at this stage unless you can show
if fixes bugs in the existing implementation (it's not easy to get this sort of
code correct, so any change involves avoidable risk) - again an alternative
function implementation (possibly with a little refactoring) would be more
acceptable.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2007-07-01 20:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-01 13:29 [linux-lvm] [PATCH]: don't use functions marked by SUSv3 as legacy Arkadiusz Miskiewicz
2007-07-01 14:48 ` Alasdair G Kergon
2007-07-01 14:58 ` Arkadiusz Miskiewicz
2007-07-01 19:11 ` Nix
2007-07-01 20:36 ` Alasdair G Kergon
2007-07-02 18:47 ` Nix
2007-07-01 20:34 ` Alasdair G Kergon [this message]
2007-07-02 7:21 ` Arkadiusz Miskiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070701203436.GK30047@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=arekm@maven.pl \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).