From: Alasdair G Kergon <agk@redhat.com>
To: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] Where to report bugs?
Date: Wed, 3 Oct 2007 20:18:21 +0100 [thread overview]
Message-ID: <20071003191821.GO18444@agk.fab.redhat.com> (raw)
In-Reply-To: <4703E000.4050307@theendofthetunnel.de>
On Wed, Oct 03, 2007 at 08:31:28PM +0200, Hannes Dorbath wrote:
> 8. Use vgreduce --removemissing to get VG data up again
> LV origin is gone and can only be brought back from backup with
> vgcfgrestore.
Right. So you're asking for vgreduce --removemissing to be enhanced
to consider just removing the snapshot and leaving behind the LV if
it possible. Seems reasonable.
The logic that needs improving is in _remove_lv() in tools/vgreduce.c
if anyone wants to have a go at fixing it.
/* Use the origin LV */
lv = snap_seg->origin;
Perhaps it should have a second variable to hold the origin, and in the
following loop only deal with the current cow instead of all of them.
(It needs to handle two cases: origin LV is gone=>loop and remove all snapshots
as well as the origin; snapshot LV only is gone=>only remove this snapshot.
Maybe push the remove_snapshot code into a separate function then call
it from two places for the two different cases, avoiding the loop for the
one snapshot only case.)
Alasdair
--
agk@redhat.com
prev parent reply other threads:[~2007-10-03 19:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-03 15:18 [linux-lvm] Where to report bugs? Hannes Dorbath
2007-10-03 17:15 ` Alasdair G Kergon
2007-10-03 18:31 ` Hannes Dorbath
2007-10-03 19:18 ` Alasdair G Kergon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071003191821.GO18444@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).