From: Alasdair G Kergon <agk@redhat.com>
To: linux-lvm@redhat.com
Cc: Daniel Mierswa <impulze@impulze.org>
Subject: [linux-lvm] FW: [lvm-devel] [PATCH 1/3] use display_size function instead of hardcoding
Date: Mon, 28 Sep 2009 13:11:53 +0100 [thread overview]
Message-ID: <20090928121153.GB5351@agk-dp.fab.redhat.com> (raw)
----- Forwarded message from Daniel Mierswa <impulze@impulze.org> -----
We should use display_size everywhere for consistency reasons. Other
commands and places that print the stripe/PE size already do that.
This might break scripts that rely on the stripe/PE size being printed
in KByte in those circumstances.
----- End forwarded message -----
Specifically this changes the following:
1) The 'PE Size' line of 'pvdisplay -v'.
2) The 'Stripe size' line of a striped segment in 'lvdisplay --maps'.
With this patch, these lines will now be controlled by --units and --nosuffix
etc.
If you have scripts that parse this output, now would be a good time to
switch to the column-based output by adding --columns or using 'pvs -o
vg_extent_size' or 'lvs -o stripesize'.
- Stripe size 64 KB
+ Stripe size 64.00 KB
- PE Size (KByte) 4096
+ PE Size 4.00 MB
Alasdair
reply other threads:[~2009-09-28 12:11 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090928121153.GB5351@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=impulze@impulze.org \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).