linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
* [linux-lvm] FW: [lvm-devel] [PATCH 1/3] use display_size function instead of hardcoding
@ 2009-09-28 12:11 Alasdair G Kergon
  0 siblings, 0 replies; only message in thread
From: Alasdair G Kergon @ 2009-09-28 12:11 UTC (permalink / raw)
  To: linux-lvm; +Cc: Daniel Mierswa

----- Forwarded message from Daniel Mierswa <impulze@impulze.org> -----

We should use display_size everywhere for consistency reasons. Other
commands and places that print the stripe/PE size already do that.
This might break scripts that rely on the stripe/PE size being printed
in KByte in those circumstances.

----- End forwarded message -----

Specifically this changes the following:

  1) The 'PE Size' line of 'pvdisplay -v'.

  2) The 'Stripe size' line of a striped segment in 'lvdisplay --maps'.

With this patch, these lines will now be controlled by --units and --nosuffix
etc.

If you have scripts that parse this output, now would be a good time to
switch to the column-based output by adding --columns or using 'pvs -o
vg_extent_size' or 'lvs -o stripesize'.

-    Stripe size		64 KB
+    Stripe size		64.00 KB
 
-  PE Size (KByte)       4096
+  PE Size               4.00 MB
 
Alasdair

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2009-09-28 12:11 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-28 12:11 [linux-lvm] FW: [lvm-devel] [PATCH 1/3] use display_size function instead of hardcoding Alasdair G Kergon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).