From: Alasdair G Kergon <agk@redhat.com>
To: Jeff <jlar310@gmail.com>
Cc: linux-lvm@redhat.com
Subject: Re: [linux-lvm] lvcreate and lvremove --quiet option is not quiet
Date: Mon, 14 Feb 2011 18:14:49 +0000 [thread overview]
Message-ID: <20110214181448.GC5825@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <AANLkTimT06YazYy8LWGQY46X_uq9QN+XCSA9cLhwQWSB@mail.gmail.com>
The simple problem is that the code today does not distinguish between
essential output (to stdout) and incidental output (to stdout).
If I run 'pvs' I expect a list of PVs.
If I run 'pvs --quiet' do I still expect to see that list?
Today, there is no distinction: pvs output and the message you're wanting
to suppress are the same category of message.
The fix is to introduce a new macro alongside log_print so we can distinguish
between the two cases, then have --quiet discard the incidental output and
review every instance of log_print to see if it needs moving into the 'discard
if quiet' category. Also provide an lvm.conf option to make --quiet the default
for those who want that. etc.
Alasdair
next prev parent reply other threads:[~2011-02-14 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-14 15:46 [linux-lvm] lvcreate and lvremove --quiet option is not quiet Jeff
2011-02-14 16:31 ` Ray Morris
2011-02-14 17:43 ` Jeff
2011-02-14 18:14 ` Alasdair G Kergon [this message]
2011-02-15 13:02 ` Jeff
2011-02-15 13:41 ` Mike Snitzer
2011-02-15 16:07 ` Jeff
2011-02-15 17:04 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110214181448.GC5825@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=jlar310@gmail.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).