* [linux-lvm] merging snapshots and lvs bug @ 2011-07-15 2:46 ben 2011-07-15 11:39 ` Alasdair G Kergon 0 siblings, 1 reply; 6+ messages in thread From: ben @ 2011-07-15 2:46 UTC (permalink / raw) To: linux-lvm Currently the first field of the attribute bits are set to 's' for a snapshot and 'S' for a merging snap. Unfortunatly 'S' was used for an invalid snapshot and lvs still uses it both ways. LVM version: 2.02.86(2) (2011-07-08) Library version: 1.02.65 (2011-07-08) Driver version: 4.20.0 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-lvm] merging snapshots and lvs bug 2011-07-15 2:46 [linux-lvm] merging snapshots and lvs bug ben @ 2011-07-15 11:39 ` Alasdair G Kergon 2011-07-15 20:01 ` ben 0 siblings, 1 reply; 6+ messages in thread From: Alasdair G Kergon @ 2011-07-15 11:39 UTC (permalink / raw) To: ben; +Cc: linux-lvm On Thu, Jul 14, 2011 at 07:46:12PM -0700, ben wrote: > Currently the first field of the attribute bits are set to 's' for a snapshot > and 'S' for a merging snap. Unfortunatly 'S' was used for an invalid snapshot > and lvs still uses it both ways. Invalid snapshot is meant to be shown by I (for invalid) in the 5th position. The lv_attr bits are: 1 Volume type: (m)irrored, (M)irrored without initial sync, (o)rigin, (O)rigin with merging snapshot, (s)napshot, merging (S)napshot, (p)vmove, (v)irtual, mirror (i)mage, mirror (I)mage out-of-sync, under (c)onversion 5 State: (a)ctive, (s)uspended, (I)nvalid snapshot, invalid (S)uspended snapshot, mapped (d)evice present without tables, mapped device present with (i)nactive table If some particular case is giving the wrong output, please show us exactly which case that is, and how the output looks, together with 'dmsetup info -c', 'dmsetup table' and 'dmsetup status'. Alasdair ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-lvm] merging snapshots and lvs bug 2011-07-15 11:39 ` Alasdair G Kergon @ 2011-07-15 20:01 ` ben 2011-07-15 22:14 ` Alasdair G Kergon 0 siblings, 1 reply; 6+ messages in thread From: ben @ 2011-07-15 20:01 UTC (permalink / raw) To: linux-lvm On July 15 04:39:01 AM Alasdair G Kergon wrote: > On Thu, Jul 14, 2011 at 07:46:12PM -0700, ben wrote: > > Currently the first field of the attribute bits are set to 's' for a > > snapshot and 'S' for a merging snap. Unfortunatly 'S' was used for an > > invalid snapshot and lvs still uses it both ways. > > Invalid snapshot is meant to be shown by I (for invalid) in the 5th > position. > > The lv_attr bits are: > > 1 Volume type: (m)irrored, (M)irrored without initial > sync, (o)rigin, (O)rigin with merging snapshot, (s)napshot, merging > (S)napshot, (p)vmove, (v)irtual, mirror (i)mage, mirror (I)mage > out-of-sync, under (c)onversion > > 5 State: (a)ctive, (s)uspended, (I)nvalid snapshot, > invalid (S)uspended snapshot, mapped (d)evice present without tables, > mapped device present with (i)nactive table > > If some particular case is giving the wrong output, please show us exactly > which case that is, and how the output looks, together with 'dmsetup info > -c', 'dmsetup table' and 'dmsetup status'. > > Alasdair It isn't a special case. Invalid snaps use capital 'S' in the first column and so do merging snaps. The invalid snap 'S' dates back to old versions of LVM. Here we have three snaps, the first is invalid, the second is merging and the last is normal: LV VG Attr LSize Origin Snap% Move Log Copy% Convert lv1 vg01 owi-a- 1023.00m lv2 vg01 Owi-a- 2.00g lv3 vg01 owi-a- 1023.00m snap1 vg01 Swi-I- 102.00m lv1 100.00 [snap2] vg01 Swi-a- 1023.00m lv2 30.25 snap3 vg01 swi-a- 102.00m lv3 0.00 vg01-snap3-cow 254 11 L--w 1 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72faEpbkeDdAe81saUi0RzfzdLRlKU3uDkw9-cow vg01-lv3 254 8 L--w 0 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72faDeYH4cymsf09Bc3eZSzBuaA1BQnsdX2G vg01-lv2 254 4 L--w 0 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72fa0N2vOYUtmgPDeaNpGw2VlFDao15M6Ilw vg01-lv1-real 254 2 L--w 2 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72facep9w6L1Pdy03yE23PuByJVKAPXZqsWf-real vg01-lv1 254 0 L--w 0 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72facep9w6L1Pdy03yE23PuByJVKAPXZqsWf vg01-snap3 254 9 L--w 0 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72faEpbkeDdAe81saUi0RzfzdLRlKU3uDkw9 vg01-lv2-real 254 6 L--w 2 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72fa0N2vOYUtmgPDeaNpGw2VlFDao15M6Ilw-real vg01-snap2 254 5 L--w 0 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72fal7p85XD8336q9jyIFDXa6Xb0JCl3ZPNX vg01-lv3-real 254 10 L--w 2 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72faDeYH4cymsf09Bc3eZSzBuaA1BQnsdX2G-real vg01-snap1 254 1 L--w 0 1 1 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72faUWfv2h31eXQkcm0f712lGTcxPKwqgzBr vg01-snap1-cow 254 3 L--w 1 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72faUWfv2h31eXQkcm0f712lGTcxPKwqgzBr-cow vg01-snap2-cow 254 7 L--w 1 1 0 LVM- UiEDiN8ISFoHCVpdhKbIJ3y8tmLY72fal7p85XD8336q9jyIFDXa6Xb0JCl3ZPNX-cow vg01-snap3-cow: 0 208896 linear vg01-lv3: 0 2095104 snapshot-origin vg01-lv2: 0 4192256 snapshot-origin vg01-lv1-real: 0 2095104 linear vg01-lv1: 0 2095104 snapshot-origin vg01-snap3: 0 2095104 snapshot 16/208896 16 vg01-lv2-real: 0 4192256 linear vg01-snap2: 0 4192256 snapshot 633768/2095104 2480 vg01-lv3-real: 0 2095104 linear vg01-snap1: 0 2095104 snapshot Invalid vg01-snap1-cow: 0 208896 linear vg01-snap2-cow: 0 2095104 linear ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-lvm] merging snapshots and lvs bug 2011-07-15 20:01 ` ben @ 2011-07-15 22:14 ` Alasdair G Kergon 2011-07-15 23:07 ` ben 2011-07-17 12:30 ` Mike Snitzer 0 siblings, 2 replies; 6+ messages in thread From: Alasdair G Kergon @ 2011-07-15 22:14 UTC (permalink / raw) To: ben; +Cc: linux-lvm On Fri, Jul 15, 2011 at 01:01:15PM -0700, ben wrote: > It isn't a special case. Invalid snaps use capital 'S' in the first column and > so do merging snaps. The invalid snap 'S' dates back to old versions of LVM. > Here we have three snaps, the first is invalid, the second is merging and the > last is normal: Oh, yes, I see. Curiously the man page used to mention that and it got replaced with S for merging. So do you think we should remove that capitalisation, as per the man page I quoted? Alasdair ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-lvm] merging snapshots and lvs bug 2011-07-15 22:14 ` Alasdair G Kergon @ 2011-07-15 23:07 ` ben 2011-07-17 12:30 ` Mike Snitzer 1 sibling, 0 replies; 6+ messages in thread From: ben @ 2011-07-15 23:07 UTC (permalink / raw) To: linux-lvm On July 15 03:14:02 PM Alasdair G Kergon wrote: > On Fri, Jul 15, 2011 at 01:01:15PM -0700, ben wrote: > > It isn't a special case. Invalid snaps use capital 'S' in the first > > column and so do merging snaps. The invalid snap 'S' dates back to old > > versions of LVM. Here we have three snaps, the first is invalid, the > > second is merging and the > > > last is normal: > Oh, yes, I see. Curiously the man page used to mention that and it got > replaced with S for merging. > > So do you think we should remove that capitalisation, as per the man page > I quoted? > > Alasdair The old meaning seems like unneeded duplication since it is flagged as invalid in another column. Also, I actually found it through liblvm2app, so it needs to be changed there as well. Thank you. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [linux-lvm] merging snapshots and lvs bug 2011-07-15 22:14 ` Alasdair G Kergon 2011-07-15 23:07 ` ben @ 2011-07-17 12:30 ` Mike Snitzer 1 sibling, 0 replies; 6+ messages in thread From: Mike Snitzer @ 2011-07-17 12:30 UTC (permalink / raw) To: ben, linux-lvm On Fri, Jul 15 2011 at 6:14pm -0400, Alasdair G Kergon <agk@redhat.com> wrote: > On Fri, Jul 15, 2011 at 01:01:15PM -0700, ben wrote: > > It isn't a special case. Invalid snaps use capital 'S' in the first column and > > so do merging snaps. The invalid snap 'S' dates back to old versions of LVM. > > Here we have three snaps, the first is invalid, the second is merging and the > > last is normal: > > Oh, yes, I see. Curiously the man page used to mention that and it got > replaced with S for merging. > > So do you think we should remove that capitalisation, as per the man page > I quoted? Yes, I think we should remove the capitalization. It is the repstr[0] = toupper(repstr[0]); in the lib/metadata/lv.c:lv_attr_dup() block I just quoted in a different mail (re: --merge bug). ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-07-17 12:30 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-07-15 2:46 [linux-lvm] merging snapshots and lvs bug ben 2011-07-15 11:39 ` Alasdair G Kergon 2011-07-15 20:01 ` ben 2011-07-15 22:14 ` Alasdair G Kergon 2011-07-15 23:07 ` ben 2011-07-17 12:30 ` Mike Snitzer
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).