linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: Joseph Glanville <joseph.glanville@orionvm.com.au>
Cc: Kent Overstreet <koverstreet@google.com>,
	linux-lvm@redhat.com, linux-bcache@vger.kernel.org,
	Kent Overstreet <kent.overstreet@gmail.com>
Subject: Re: [linux-lvm] bcache and dm targets (specifically lvm)
Date: Sun, 4 Mar 2012 09:21:40 -0500	[thread overview]
Message-ID: <20120304142139.GA10510@redhat.com> (raw)
In-Reply-To: <CAOzFzEiSR1izXGuS+djSpCJOTnaPU6KetR=wB8tXmPopUk4Jrg@mail.gmail.com>

On Fri, Mar 02 2012 at  9:28pm -0500,
Joseph Glanville <joseph.glanville@orionvm.com.au> wrote:

> Ahh!
> 
> I didn't know LVM had a device type lookup table. You can see if you
> look further that it also reads new types from the lvm.conf file.
> Adding this line to lvm.conf fixes the problem:
> 
> types = [ "bcache", 16 ]
>
> I would imagine if merged it would be added to the internal compiled in table.

Assuming bcache devices are partitionable 16 would be used (like patch
below), if they aren't then 1 would be used.

Kent,

I know you were frustrated with DM in the past and that is why you
created your own device type.

I'll be looking much closer at bcache in the next week or so.  I'm
starting to work on a DM-based caching target... it will re-use the
drivers/md/persistent-data/ infrastructure we've established as part of
the DM Thin Provisioning target.

Anyway, even if bcache remains to be a standalone (non-DM) block device
in the future I'll have a look at it with an eye toward code sharing
that might allow other caching layers to build on a common layer.  Even
if the common code is a policy engine I think it'd be cool to allow
sharing of policy across caching targets.

That said I'm also open to porting bcache to DM... but time will tell.
I'll grab the latest bcache code and jump on the linux-bcache list and
we can take it one step at a time.

---
 lib/filters/filter.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/lib/filters/filter.c b/lib/filters/filter.c
index 4c3d3b7..f4a9615 100644
--- a/lib/filters/filter.c
+++ b/lib/filters/filter.c
@@ -129,6 +129,7 @@ static const device_info_t device_info[] = {
 	{"mmc", 16},		/* MMC block device */
 	{"blkext", 1},		/* Extended device partitions */
 	{"fio", 16},		/* Fusion */
+	{"bcache", 16},		/* bcache */
 	{NULL, 0}
 };
 

  parent reply	other threads:[~2012-03-04 14:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CAOzFzEjKapphA5NKCWbEyx4nvjWw+e_dxr+fOLr8f5j586jiyA@mail.gmail.com>
     [not found] ` <CAOzFzEjffLGjYhOznTo1F3moHLq+nvKYZFoy7mkU-q8RPDd9oQ@mail.gmail.com>
     [not found]   ` <CAC7rs0vpQAaF9uNhhy2ziLa+3EB6udJVRjGwf=RVoSk0TxuDcw@mail.gmail.com>
     [not found]     ` <CAC7rs0us5Xqag_AWq=wsFYqn3Fub3qt59a9=vDeS5cLh2oOg0Q@mail.gmail.com>
     [not found]       ` <CAOzFzEifqyFz2G=0OEPA9BN8-kU3MabUhGmU7-jSQCxwPcHrpw@mail.gmail.com>
     [not found]         ` <CAH+dOx+eWJKvKz=HEGHaPu8tqqz2CqVjUC1+0GJqta0GE4aYNw@mail.gmail.com>
     [not found]           ` <CAOzFzEj=gBXL9UaVytrebU3gr2p1rJaMVPkz1X0oZOALQKbcNA@mail.gmail.com>
2012-03-03  2:17             ` [linux-lvm] bcache and dm targets (specifically lvm) Kent Overstreet
2012-03-03  2:28               ` Joseph Glanville
2012-03-03  2:44                 ` Kent Overstreet
2012-03-04 14:21                 ` Mike Snitzer [this message]
2012-03-06  7:03                   ` Kent Overstreet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120304142139.GA10510@redhat.com \
    --to=snitzer@redhat.com \
    --cc=joseph.glanville@orionvm.com.au \
    --cc=kent.overstreet@gmail.com \
    --cc=koverstreet@google.com \
    --cc=linux-bcache@vger.kernel.org \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).