From: Miquel van Smoorenburg <mikevs@xs4all.net>
To: Alasdair G Kergon <agk@redhat.com>
Cc: LVM general discussion and development <linux-lvm@redhat.com>
Subject: Re: [linux-lvm] [PATCH] automatically filter disks with imsm or ddf superblocks, v2
Date: Sat, 22 Sep 2012 18:34:12 +0200 [thread overview]
Message-ID: <20120922163411.GA6975@xs4all.net> (raw)
In-Reply-To: <20120917100750.GA2316@xs4all.net>
According to Miquel van Smoorenburg:
> Here's version two of the patch. I've taken your comments into account,
> and I've also fixed some wrong assumptions (like size being in sectors,
> not bytes). It's been tested on both imsm and ddf formatted disks.
Hmm, I caused a small cosmetic bug when I implemented one of
your suggestions, this should fix it (I'l send a full patch as well):
--- a/lib/filters/filter-md.c 2012-09-16 21:05:34.000000000 +0000
+++ b/lib/filters/filter-md.c 2012-09-22 16:24:18.528609536 +0000
@@ -29,7 +29,7 @@
return 1;
if ((ret = dev_is_md(dev, NULL)) != 0)
- sb_type = "ddf";
+ sb_type = "md";
else if ((ret = dev_is_ddf(dev, NULL)) != 0)
sb_type = "ddf";
else if ((ret = dev_is_imsm(dev, NULL)) != 0)
prev parent reply other threads:[~2012-09-22 16:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-05 15:47 [linux-lvm] automatically filter disks with imsm or ddf superblocks Miquel van Smoorenburg
2012-09-14 13:35 ` Alasdair G Kergon
2012-09-14 20:29 ` Miquel van Smoorenburg
2012-09-17 10:07 ` [linux-lvm] [PATCH] automatically filter disks with imsm or ddf superblocks, v2 Miquel van Smoorenburg
2012-09-22 16:34 ` Miquel van Smoorenburg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120922163411.GA6975@xs4all.net \
--to=mikevs@xs4all.net \
--cc=agk@redhat.com \
--cc=linux-lvm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).