From: Mike Snitzer <msnitzer@fedoraproject.org>
To: James Antill <james@fedoraproject.org>
Cc: okozina@fedoraproject.org, yum-devel@lists.baseurl.org,
linux-lvm@redhat.com
Subject: Re: [linux-lvm] [PATCH 4/2] fs snapshot plugin: add LVM tag to allow tools to link pre and post snapshots
Date: Tue, 12 Mar 2013 16:30:49 -0400 [thread overview]
Message-ID: <20130312203049.GA16198@redhat.com> (raw)
In-Reply-To: <1363117923.24725.242.camel@code.and.org>
On Tue, Mar 12 2013 at 3:52pm -0400,
James Antill <james@fedoraproject.org> wrote:
> On Tue, 2013-03-12 at 14:09 -0400, Mike Snitzer wrote:
> > On Tue, Mar 12 2013 at 12:41pm -0400,
> > James Antill <james@fedoraproject.org> wrote:
> > > Using globals should work, the only real problem is if some python API
> > > creates multiple YumBase() instances (but although we've worried about
> > > that, nothing has ever really done it AFAIK).
> >
> > Just adding a single global caused the plugin to fail: global foo = None
>
> That's a syntax error, python is much more annoying about globals than
> perl (or pretty much any other language :).
> Also note that you can pass "-d 9" (maybe even just -v) to yum get the
> traceback from plugins, we suppress them on load, by default, as that's
> much better for users.
OK, thanks.
> > But yeah, I didn't know how to store the timestamp.
> >
> > I'll send a simpler v3 now.. thanks for your help!
>
> Looks fine, I've pushed it and built it in rawhide (on F19 branch too).
Much appreciated!
next prev parent reply other threads:[~2013-03-12 20:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-10 16:18 [linux-lvm] [PATCH 0/2] yum-utils fs snapshot plugin: fix old LVM snapshots and add thinp support Mike Snitzer
2013-03-10 16:18 ` [linux-lvm] [PATCH 1/2] fs snapshot plugin: fix inspect_volume_lvm to use supported dmsetup splitname options Mike Snitzer
2013-03-10 16:18 ` [linux-lvm] [PATCH 2/2] fs snapshot plugin: add support for snapshotting thinly provisioned LVM volumes Mike Snitzer
2013-03-11 21:25 ` [linux-lvm] [PATCH 3/2] fs snapshot plugin: add ability to create snapshots during post transaction Mike Snitzer
2013-03-11 21:25 ` [linux-lvm] [PATCH 4/2] fs snapshot plugin: add LVM tag to allow tools to link pre and post snapshots Mike Snitzer
2013-03-12 13:46 ` [linux-lvm] [Yum-devel] " James Antill
2013-03-12 14:41 ` [linux-lvm] " Mike Snitzer
2013-03-12 16:41 ` James Antill
2013-03-12 18:09 ` Mike Snitzer
2013-03-12 19:52 ` [linux-lvm] [Yum-devel] " James Antill
2013-03-12 20:30 ` Mike Snitzer [this message]
2013-03-12 15:00 ` [linux-lvm] [PATCH 4/2 v2] " Mike Snitzer
2013-03-12 18:16 ` [linux-lvm] [PATCH 4/2 v3] " Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130312203049.GA16198@redhat.com \
--to=msnitzer@fedoraproject.org \
--cc=james@fedoraproject.org \
--cc=linux-lvm@redhat.com \
--cc=okozina@fedoraproject.org \
--cc=yum-devel@lists.baseurl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).