From mboxrd@z Thu Jan  1 00:00:00 1970
Date: Tue, 12 Mar 2013 16:30:49 -0400
From: Mike Snitzer <msnitzer@fedoraproject.org>
Message-ID: <20130312203049.GA16198@redhat.com>
References: <1362932290-28679-1-git-send-email-msnitzer@fedoraproject.org>
	<1363037150-8757-1-git-send-email-msnitzer@fedoraproject.org>
	<1363037150-8757-2-git-send-email-msnitzer@fedoraproject.org>
	<1363095972.24725.231.camel@code.and.org>
	<20130312144129.GA13459@redhat.com>
	<1363106460.24725.236.camel@code.and.org>
	<20130312180924.GA14883@redhat.com>
	<1363117923.24725.242.camel@code.and.org>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <1363117923.24725.242.camel@code.and.org>
Subject: Re: [linux-lvm] [PATCH 4/2] fs snapshot plugin: add LVM tag to
 allow tools to link pre and post snapshots
Reply-To: LVM general discussion and development <linux-lvm@redhat.com>
List-Id: LVM general discussion and development <linux-lvm.redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-lvm>,
	<mailto:linux-lvm-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-lvm>
List-Post: <mailto:linux-lvm@redhat.com>
List-Help: <mailto:linux-lvm-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-lvm>,
	<mailto:linux-lvm-request@redhat.com?subject=subscribe>
List-Id: <linux-lvm.redhat.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: James Antill <james@fedoraproject.org>
Cc: okozina@fedoraproject.org, yum-devel@lists.baseurl.org, linux-lvm@redhat.com

On Tue, Mar 12 2013 at  3:52pm -0400,
James Antill <james@fedoraproject.org> wrote:

> On Tue, 2013-03-12 at 14:09 -0400, Mike Snitzer wrote:
> > On Tue, Mar 12 2013 at 12:41pm -0400,
> > James Antill <james@fedoraproject.org> wrote:
> > >  Using globals should work, the only real problem is if some python API
> > > creates multiple YumBase() instances (but although we've worried about
> > > that, nothing has ever really done it AFAIK).
> > 
> > Just adding a single global caused the plugin to fail: global foo = None
> 
>  That's a syntax error, python is much more annoying about globals than
> perl (or pretty much any other language :).
>  Also note that you can pass "-d 9" (maybe even just -v) to yum get the
> traceback from plugins, we suppress them on load, by default, as that's
> much better for users.

OK, thanks.
 
> >   But yeah, I didn't know how to store the timestamp.
> > 
> > I'll send a simpler v3 now.. thanks for your help!
> 
>  Looks fine, I've pushed it and built it in rawhide (on F19 branch too).

Much appreciated!