linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Alasdair G Kergon <agk@redhat.com>
To: linux-lvm@redhat.com
Subject: Re: [linux-lvm] Missing error handling in lv_snapshot_remove
Date: Wed, 7 Aug 2013 14:32:58 +0100	[thread overview]
Message-ID: <20130807133258.GA28325@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <20130807123656.GA18854@mail.waldi.eu.org>

On Wed, Aug 07, 2013 at 02:36:57PM +0200, Bastian Blank wrote:
> I'm a developer and use it to trigger an error condition. Please don't
> start with that crap about what a user should or should not do.
 
Use the software however you want, but upstream LVM only supports the
direct use of devices exposed under /dev/$VG.  Any other devices it
creates are private and direct access is unsupported and can cause
problems as you have demonstrated.

These situations you are investigating are caused by external
interference with LVM operations and should not occur if LVM is used
as intended, so it is better for the code to 'fail safe' and stop so the
cause can be investigated and then the system cleaned up safely.  An
attempt to clean up automatically would risk making the situation worse.

Alasdair

  reply	other threads:[~2013-08-07 13:33 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-06 17:37 [linux-lvm] Missing error handling in lv_snapshot_remove Bastian Blank
2013-08-07  9:13 ` Zdenek Kabelac
2013-08-07 12:36   ` Bastian Blank
2013-08-07 13:32     ` Alasdair G Kergon [this message]
2013-08-07 15:13     ` Zdenek Kabelac
2013-08-08 13:33   ` Ritesh Raj Sarraf
2013-08-09  9:50     ` Zdenek Kabelac
2013-08-07  9:22 ` Andreas Pflug
2013-08-07  9:41   ` Zdenek Kabelac
2013-08-07 17:18     ` Andreas Pflug
2013-08-08 10:01       ` Zdenek Kabelac
2013-08-09  7:57         ` Andreas Pflug
2013-08-09  9:40           ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130807133258.GA28325@agk-dp.fab.redhat.com \
    --to=agk@redhat.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).