linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Martin Wilck <martin.wilck@suse.com>
To: Christophe Varoqui <christophe.varoqui@opensvc.com>,
	Benjamin Marzinski <bmarzins@redhat.com>
Cc: dm-devel@lists.linux.dev, linux-lvm@lists.linux.dev,
	Zdenek Kabelac <zkabelac@redhat.com>,
	Peter Rajnoha <prajnoha@redhat.com>,
	Sergio Durigan Junior <sergiodj@sergiodj.net>,
	Chris Hofstaedtler <zeha@debian.org>
Subject: [PATCH 6/6] multipathd: don't activate socket activation by default
Date: Mon,  5 Feb 2024 13:46:38 +0100	[thread overview]
Message-ID: <20240205124638.17877-7-mwilck@suse.com> (raw)
In-Reply-To: <20240205124638.17877-1-mwilck@suse.com>

Socket activation will start multipathd on systems that don't have multipath
hardware. This is often not desired.  On systems that do have multipath
hardware, OTOH, it is highly recommended to enable multipathd.service directly
rather than have it started via socket activation.  Therefore don't activate
the socket by default.  multipathd still supports socket activation, so users
who find it useful can disable multipathd.service and activate the socket.

Fixes: https://github.com/opensvc/multipath-tools/issues/76
Signed-off-by: Martin Wilck <mwilck@suse.com>
Cc: Sergio Durigan Junior <sergiodj@sergiodj.net>
Cc: Chris Hofstaedtler <zeha@debian.org>
---
 multipathd/multipathd.socket | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/multipathd/multipathd.socket b/multipathd/multipathd.socket
index c777e5e..6a62f5f 100644
--- a/multipathd/multipathd.socket
+++ b/multipathd/multipathd.socket
@@ -10,4 +10,6 @@ Before=sockets.target
 ListenStream=@/org/kernel/linux/storage/multipathd
 
 [Install]
-WantedBy=sockets.target
+# Socket activation for multipathd is disabled by default.
+# Activate it here if you find it useful.
+# WantedBy=sockets.target
-- 
2.43.0


  parent reply	other threads:[~2024-02-05 12:46 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 12:46 [PATCH 0/6] multipath-tools: udev rules and service improvements Martin Wilck
2024-02-05 12:46 ` [PATCH 1/6] 11-dm-mpath.rules: don't import properties that are already set Martin Wilck
2024-02-05 20:44   ` Benjamin Marzinski
2024-02-06 10:50     ` Martin Wilck
2024-02-09  0:30       ` Benjamin Marzinski
2024-02-09 15:35         ` Martin Wilck
2024-02-05 12:46 ` [PATCH 2/6] 11-dm-mpath.rules: fix list of imported properties Martin Wilck
2024-02-09  0:32   ` Benjamin Marzinski
2024-02-05 12:46 ` [PATCH 3/6] 11-dm-mpath.rules: use import logic like 13-dm-disk.rules Martin Wilck
2024-02-09  0:36   ` Benjamin Marzinski
2024-02-09 15:38     ` Martin Wilck
2024-02-05 12:46 ` [PATCH 4/6] 11-dm-mpath.rules: handle reloads during coldplug events Martin Wilck
2024-02-09  1:03   ` Benjamin Marzinski
2024-02-09 15:53     ` Martin Wilck
2024-02-09 16:13       ` Benjamin Marzinski
2024-02-09 16:15       ` Benjamin Marzinski
2024-02-05 12:46 ` [PATCH 5/6] multipath: udev rules: use configured $(bindir) in udev rules Martin Wilck
2024-02-09  1:04   ` Benjamin Marzinski
2024-02-05 12:46 ` Martin Wilck [this message]
2024-02-09  1:05   ` [PATCH 6/6] multipathd: don't activate socket activation by default Benjamin Marzinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240205124638.17877-7-mwilck@suse.com \
    --to=martin.wilck@suse.com \
    --cc=bmarzins@redhat.com \
    --cc=christophe.varoqui@opensvc.com \
    --cc=dm-devel@lists.linux.dev \
    --cc=linux-lvm@lists.linux.dev \
    --cc=prajnoha@redhat.com \
    --cc=sergiodj@sergiodj.net \
    --cc=zeha@debian.org \
    --cc=zkabelac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).