linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Zdenek Kabelac <zkabelac@redhat.com>
To: Martin Wilck <martin.wilck@suse.com>,
	"demi@invisiblethingslab.com" <demi@invisiblethingslab.com>,
	"teigland@redhat.com" <teigland@redhat.com>
Cc: Heming Zhao <heming.zhao@suse.com>, Glass Su <glass.su@suse.com>,
	"bmarzins@redhat.com" <bmarzins@redhat.com>,
	"hare@suse.de" <hare@suse.de>,
	"prajnoha@redhat.com" <prajnoha@redhat.com>,
	"linux-lvm@lists.linux.dev" <linux-lvm@lists.linux.dev>
Subject: Re: discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83
Date: Mon, 20 Nov 2023 11:13:01 +0100	[thread overview]
Message-ID: <247e1290-78b7-46fe-b10a-80a571bdec09@redhat.com> (raw)
In-Reply-To: <2e718cd763c6a69162be0d6d7e5211f73bf84a19.camel@suse.com>

Dne 17. 11. 23 v 22:05 Martin Wilck napsal(a):
> On Fri, 2023-11-17 at 16:03 -0500, Demi Marie Obenour wrote:
>> On Fri, Nov 17, 2023 at 02:16:48PM -0600, David Teigland wrote:
>>> On Fri, Nov 17, 2023 at 02:57:35PM -0500, Demi Marie Obenour wrote:
>>>>> Yes, the devices file is intended to be a default feature of
>>>>> lvm since the
>>>>> commit above.
>>>> Could LVM issue a deprecation warning if DEFAULT_USE_DEVICES_FILE
>>>> is set
>>>> to 0 or system.devices is not set at runtime?
>>> No, deprecated implies we're planning to remove it, which we
>>> probably
>>> never will.
>> Still, distros need to know that they should make the change.
> I think David and Zdenek did not say distros _should_ make the change.
> They can, but it requires substantial adaptations and testing.


There is quite 'noticeable' difference in behavior of lvm2 with this change.

So having users without support behind their backs facing the sudden change 
where lvm2 does no longer sees all devices as it used to is somewhat 
problematic - we are adding changes and messages to the tool to improve this 
as we meet the real life situation. Once there will be enough coverage - the 
change will likely happen.

But as mentioned earlier, there are situation where the original filtering is 
simply easier to deal with. So both variants will stay in place.


Zdenek




  reply	other threads:[~2023-11-20 10:13 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 12:51 discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83 Heming Zhao
2023-11-13 11:52 ` Martin Wilck
2023-11-13 13:52   ` Peter Rajnoha
2023-11-13 18:38     ` David Teigland
2023-11-14  7:55       ` Peter Rajnoha
2023-11-14 16:30         ` David Teigland
2023-11-15  8:51           ` Peter Rajnoha
2023-11-15 11:36             ` Heming Zhao
2023-11-15 19:12               ` David Teigland
2023-11-16 13:37                 ` Zdenek Kabelac
2023-11-16 13:46                   ` Martin Wilck
2023-11-16 14:03                     ` Zdenek Kabelac
2023-11-16 15:29                       ` Martin Wilck
2023-11-16 17:13                         ` David Teigland
2023-11-16 15:10                   ` David Teigland
2023-11-16 15:40                     ` Martin Wilck
2023-11-16 15:48                       ` Zdenek Kabelac
2023-11-16 17:27                         ` David Teigland
2023-11-16 15:59                     ` Zdenek Kabelac
2023-11-17  1:47                   ` Demi Marie Obenour
2023-11-17 15:25                     ` David Teigland
2023-11-17 19:57                       ` Demi Marie Obenour
2023-11-17 20:16                         ` David Teigland
2023-11-17 21:03                           ` Demi Marie Obenour
2023-11-17 21:05                             ` Martin Wilck
2023-11-20 10:13                               ` Zdenek Kabelac [this message]
2023-11-15 21:02             ` David Teigland
2023-11-15 21:46               ` Martin Wilck
2023-11-16 16:11                 ` David Teigland
2023-11-14 10:44       ` Martin Wilck
2023-11-14 12:18         ` Heming Zhao
2023-11-14 17:16           ` David Teigland
2023-11-14 17:00         ` David Teigland
2023-11-14 17:48           ` Martin Wilck
2023-11-14 17:58             ` Martin Wilck
2023-11-14 21:02               ` David Teigland
2023-11-15  7:35                 ` Martin Wilck
2023-11-16 16:34                   ` David Teigland
2023-11-16 20:22                     ` Benjamin Marzinski
2023-11-14 20:51             ` David Teigland
2023-11-15  5:15               ` Heming Zhao
2023-11-15  7:39                 ` Martin Wilck
2023-11-21 14:39   ` Martin Wilck
2023-11-21 17:56     ` David Teigland
2023-11-21 18:10       ` Martin Wilck
2023-11-21 18:25         ` David Teigland
2023-11-21 20:35           ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=247e1290-78b7-46fe-b10a-80a571bdec09@redhat.com \
    --to=zkabelac@redhat.com \
    --cc=bmarzins@redhat.com \
    --cc=demi@invisiblethingslab.com \
    --cc=glass.su@suse.com \
    --cc=hare@suse.de \
    --cc=heming.zhao@suse.com \
    --cc=linux-lvm@lists.linux.dev \
    --cc=martin.wilck@suse.com \
    --cc=prajnoha@redhat.com \
    --cc=teigland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).