Linux LVM users
 help / color / mirror / Atom feed
From: Michael Marxmeier <mike@msede.com>
To: linux-lvm@msede.com
Subject: [linux-lvm] Difficulty with RH 6.x and LVM
Date: Thu, 27 Apr 2000 21:20:35 +0200	[thread overview]
Message-ID: <39089303.94A281A4@msede.com> (raw)

Forwarded message from Eric M. Hopper <hopper@omnifarious.mn.org> ...

-------- Original Message --------
From: "Eric M. Hopper" <hopper@omnifarious.mn.org>
Subject: Difficulty with RH 6.x and LVM
Message-ID: <20000427112349.A21088@omnifarious.mn.org>


	The lines in the patches assume that the kernel to be patched
calls md_make_request like this:

md_make_request(MINOR (bh[i]->b_dev), rw, bh[i]);

	The RedHat 6.x kernels seem to have a different md_make_request
that they call like this:

md_make_request(bh[i], rw);

	As you may notice, there is a large discrepancy here that is
rather worrisome, since the change to use rdev instead of dev can't be
made in any way.

	In drivers/block/md.c, RedHat's md_make_request looks like this:

int md_make_request (struct buffer_head * bh, int rw)
{
	int err;
	mddev_t *mddev = kdev_to_mddev(bh->b_dev);

	if (!mddev || !mddev->pers) {
		err = -ENXIO;
		goto out;
	}

	if (mddev->pers->make_request) {
		if (buffer_locked(bh)) {
			err = 0;
			goto out;
		}
		set_bit(BH_Lock, &bh->b_state);
		if (rw == WRITE || rw == WRITEA) {
			if (!buffer_dirty(bh)) {
				bh->b_end_io(bh, buffer_uptodate(bh));
				err = 0;
				goto out;
			}
		}
		if (rw == READ || rw == READA) {
			if (buffer_uptodate(bh)) {
				bh->b_end_io(bh, buffer_uptodate(bh));
				err = 0;
				goto out;
			}
		}
		err = mddev->pers->make_request(mddev, rw, bh);
	} else {
		make_request (MAJOR(bh->b_rdev), rw, bh);
		err = 0;
	}
out:
	return err;
}

	Any suggestions as to how I apply the patch?

Thanks,
--
Its name is Public Opinion.  It is held in reverence. It settles
everything.
Some think it is the voice of God.  Loyalty to petrified opinion never
yet
broke a chain or freed a human soul.     ---Mark Twain
-- Eric Hopper (hopper@omnifarious.mn.org 
http://omnifarious.mn.org/~hopper) --

                 reply	other threads:[~2000-04-27 19:20 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=39089303.94A281A4@msede.com \
    --to=mike@msede.com \
    --cc=hopper@omnifarious.mn.org \
    --cc=linux-lvm@msede.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox