* [linux-lvm] [BUG] lvm beta7 and ac11 problems
@ 2001-04-21 14:00 Ed Tomlinson
2001-04-21 14:20 ` [linux-lvm] " Jens Axboe
2001-04-21 15:33 ` Alan Cox
0 siblings, 2 replies; 6+ messages in thread
From: Ed Tomlinson @ 2001-04-21 14:00 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-openlvm, linux-lvm, Alan Cox
Hi,
building a kernel with 2.4.3-ac11 and lvm beta7 + vfs_locking_patch-2.4.2 yields:
oscar# depmod -ae 2.4.3-ac11
depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac11/kernel/drivers/md/lvm-mod.o
depmod: get_hardblocksize
ideas?
Ed Tomlinson
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-lvm] Re: [BUG] lvm beta7 and ac11 problems
2001-04-21 14:00 [linux-lvm] [BUG] lvm beta7 and ac11 problems Ed Tomlinson
@ 2001-04-21 14:20 ` Jens Axboe
2001-04-23 8:51 ` Martin Dalecki
2001-04-21 15:33 ` Alan Cox
1 sibling, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2001-04-21 14:20 UTC (permalink / raw)
To: Ed Tomlinson; +Cc: linux-kernel, linux-openlvm, linux-lvm, Alan Cox
On Sat, Apr 21 2001, Ed Tomlinson wrote:
> Hi,
>
> building a kernel with 2.4.3-ac11 and lvm beta7 + vfs_locking_patch-2.4.2 yields:
>
> oscar# depmod -ae 2.4.3-ac11
> depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac11/kernel/drivers/md/lvm-mod.o
> depmod: get_hardblocksize
>
> ideas?
s/get_hardblocksize/get_hardsect_size
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-lvm] Re: [BUG] lvm beta7 and ac11 problems
2001-04-21 14:20 ` [linux-lvm] " Jens Axboe
@ 2001-04-23 8:51 ` Martin Dalecki
2001-04-23 13:16 ` Jeff Chua
0 siblings, 1 reply; 6+ messages in thread
From: Martin Dalecki @ 2001-04-23 8:51 UTC (permalink / raw)
To: Jens Axboe; +Cc: Ed Tomlinson, linux-kernel, linux-openlvm, linux-lvm, Alan Cox
Jens Axboe wrote:
>
> On Sat, Apr 21 2001, Ed Tomlinson wrote:
> > Hi,
> >
> > building a kernel with 2.4.3-ac11 and lvm beta7 + vfs_locking_patch-2.4.2 yields:
> >
> > oscar# depmod -ae 2.4.3-ac11
> > depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac11/kernel/drivers/md/lvm-mod.o
> > depmod: get_hardblocksize
> >
> > ideas?
>
> s/get_hardblocksize/get_hardsect_size
And don't forget to have a look whatever the get_hardblocksize == 0
check
or similar can't be killed alltogether as well....
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-lvm] Re: [BUG] lvm beta7 and ac11 problems
2001-04-23 8:51 ` Martin Dalecki
@ 2001-04-23 13:16 ` Jeff Chua
2001-04-23 13:18 ` Martin Dalecki
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Chua @ 2001-04-23 13:16 UTC (permalink / raw)
To: Martin Dalecki
Cc: Jens Axboe, Ed Tomlinson, linux-kernel, linux-openlvm, linux-lvm,
Alan Cox
On Mon, 23 Apr 2001, Martin Dalecki wrote:
> > > depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac11/kernel/drivers/md/lvm-mod.o
try this (after you have applied the patch for lvm 0.9.1_beta7) ...
Jeff
[jchua@fedex.com]
--- /u2/src/linux/drivers/md/lvm.c.org Mon Apr 23 21:11:32 2001
+++ /u2/src/linux/drivers/md/lvm.c Mon Apr 23 21:12:27 2001
@@ -1791,7 +1791,7 @@
int max_hardblocksize = 0, hardblocksize;
for (le = 0; le < lv->lv_allocated_le; le++) {
- hardblocksize =
get_hardblocksize(lv->lv_current_pe[le].dev);
+ hardblocksize =
get_hardsect_size(lv->lv_current_pe[le].dev);
if (hardblocksize == 0)
hardblocksize = 512;
if (hardblocksize > max_hardblocksize)
@@ -1801,7 +1801,7 @@
if (lv->lv_access & LV_SNAPSHOT) {
for (e = 0; e < lv->lv_remap_end; e++) {
hardblocksize =
- get_hardblocksize(
+ get_hardsect_size(
lv->lv_block_exception[e].rdev_new);
if (hardblocksize == 0)
hardblocksize = 512;
^ permalink raw reply [flat|nested] 6+ messages in thread* [linux-lvm] Re: [BUG] lvm beta7 and ac11 problems
2001-04-23 13:16 ` Jeff Chua
@ 2001-04-23 13:18 ` Martin Dalecki
0 siblings, 0 replies; 6+ messages in thread
From: Martin Dalecki @ 2001-04-23 13:18 UTC (permalink / raw)
To: Jeff Chua
Cc: Jens Axboe, Ed Tomlinson, linux-kernel, linux-openlvm, linux-lvm,
Alan Cox
Jeff Chua wrote:
>
> On Mon, 23 Apr 2001, Martin Dalecki wrote:
>
> > > > depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac11/kernel/drivers/md/lvm-mod.o
>
> try this (after you have applied the patch for lvm 0.9.1_beta7) ...
>
> Jeff
> [jchua@fedex.com]
>
> --- /u2/src/linux/drivers/md/lvm.c.org Mon Apr 23 21:11:32 2001
> +++ /u2/src/linux/drivers/md/lvm.c Mon Apr 23 21:12:27 2001
> @@ -1791,7 +1791,7 @@
> int max_hardblocksize = 0, hardblocksize;
>
> for (le = 0; le < lv->lv_allocated_le; le++) {
> - hardblocksize =
> get_hardblocksize(lv->lv_current_pe[le].dev);
> + hardblocksize =
> get_hardsect_size(lv->lv_current_pe[le].dev);
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> if (hardblocksize == 0)
> hardblocksize = 512;
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Those above two code lines can be killed, since get_hardsect_size
is returning the default sector size of Linux (namely 512 bytes)
in case the driver didn't have a chance to set hardsect_size[] array
in time for usage (Which shouldn't happen anyway).
> if (hardblocksize > max_hardblocksize)
> @@ -1801,7 +1801,7 @@
> if (lv->lv_access & LV_SNAPSHOT) {
> for (e = 0; e < lv->lv_remap_end; e++) {
> hardblocksize =
> - get_hardblocksize(
> + get_hardsect_size(
>
> lv->lv_block_exception[e].rdev_new);
> if (hardblocksize == 0)
> hardblocksize = 512;
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 6+ messages in thread
* [linux-lvm] Re: [BUG] lvm beta7 and ac11 problems
2001-04-21 14:00 [linux-lvm] [BUG] lvm beta7 and ac11 problems Ed Tomlinson
2001-04-21 14:20 ` [linux-lvm] " Jens Axboe
@ 2001-04-21 15:33 ` Alan Cox
1 sibling, 0 replies; 6+ messages in thread
From: Alan Cox @ 2001-04-21 15:33 UTC (permalink / raw)
To: Ed Tomlinson; +Cc: linux-kernel, linux-openlvm, linux-lvm, Alan Cox
> building a kernel with 2.4.3-ac11 and lvm beta7 + vfs_locking_patch-2.4.2 yields:
>
> oscar# depmod -ae 2.4.3-ac11
> depmod: *** Unresolved symbols in /lib/modules/2.4.3-ac11/kernel/drivers/md/lvm-mod.o
> depmod: get_hardblocksize
>
> ideas?
get_hardblock_size has been removed. Take a look at the fs parts of the
ac10->11 diff and you'll see the trivial fixup you need to add
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-04-23 13:18 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-04-21 14:00 [linux-lvm] [BUG] lvm beta7 and ac11 problems Ed Tomlinson
2001-04-21 14:20 ` [linux-lvm] " Jens Axboe
2001-04-23 8:51 ` Martin Dalecki
2001-04-23 13:16 ` Jeff Chua
2001-04-23 13:18 ` Martin Dalecki
2001-04-21 15:33 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).