Re: [linux-lvm] LVM and -ac kernels?

[Jim Cromie <jcromie@divsol.com>]

Benjamin Reed wrote:

> I've tried applying 1.0.1-rc2 to 2.4.9-ac9 and it appears
> that something's not matching up; I was wondering if anyone
> has had any luck with the 2.4.9 ac kernels?
>
> I get a reject in the Makefile for something that Alan's
> already added to his tree, and when I build, I get:
>
> ---(snip!)---
> make[3]: Entering directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
> gcc -D__KERNEL__ -I/usr/src/linux-2.4.9-ac9-eb1/include -Wall -Wstrict-prototypes -Wno-trigraphs -O2 -fomit-frame-pointer -fno-strict-aliasing -fno-common -pipe -mpreferred-stack-boundary=2 -march=i686    -c -o lvm.o lvm.c
> lvm.c: In function `__extend_reduce':
> lvm.c:2329: warning: implicit declaration of function `min'
> lvm.c:2329: parse error before `uint'
> lvm.c:2343: parse error before `uint'
> lvm.c:2280: warning: `end' might be used uninitialized in this function
> lvm.c:2339: warning: `end' might be used uninitialized in this function
> make[3]: *** [lvm.o] Error 1
> make[3]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
> make[2]: *** [first_rule] Error 2
> make[2]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers/md'
> make[1]: *** [_subdir_md] Error 2
> make[1]: Leaving directory `/usr/src/linux-2.4.9-ac9-eb1/drivers'
> make: *** [_dir_drivers] Error 2
> ---(snip!)---
>
> Feel free to tell me "don't bother with -ac kernels and LVM", all
> I *truly* care about from the -ac tree is ext3, but it would be nice
> if it's a simple fix.
>
> TIA,

simple enough.

in line 2329, s/uint, /
again on 2343,

recompile, find similar errors in lvm-snap.c,

again remove 1st of 3 parameters.

reason:

min( type, a, b )  now restored to min ( a, b)

cuz

#define min (a, b)
is redefined to be type-safe ( new macro def  insists that typeof (a) == typeof (b) )
without requireing type param