linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: John Spencer <maillist-lvm@barfooze.de>
To: linux-lvm@redhat.com
Subject: [linux-lvm] [PATCH] fix missing include directives
Date: Sat, 02 Feb 2013 17:14:15 +0100	[thread overview]
Message-ID: <510D3B57.3020607@barfooze.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 253 bytes --]

on glibc, those are erroneously (namespace pollution) pulled in via 
other headers. this doesn't work with conformant libcs (musl libc in 
this case), we simply need to include all needed headers.

Signed-Off-By: John Spencer <maillist-lvm@barfooze.de>

[-- Attachment #2: lvm2-includes.patch --]
[-- Type: text/x-patch, Size: 902 bytes --]

--- a/libdm/mm/pool-fast.c	2012-11-24 19:05:17.413015858 +0100
+++ b/libdm/mm/pool-fast.c	2012-11-24 19:05:56.589926540 +0100
@@ -18,6 +18,7 @@
 #endif
 
 #include "dmlib.h"
+#include <stddef.h>
 #include <malloc.h>
 
 struct chunk {
--- a/daemons/dmeventd/dmeventd.c	2012-11-24 19:08:48.981918074 +0100
+++ b/daemons/dmeventd/dmeventd.c	2012-11-24 19:09:25.822750433 +0100
@@ -37,6 +37,7 @@
 #include <unistd.h>
 #include <signal.h>
 #include <arpa/inet.h>		/* for htonl, ntohl */
+#include <fcntl.h>
 
 #ifdef linux
 /*
--- a/scripts/lvm2_activation_generator_systemd_red_hat.c	2012-11-24 20:06:19.481792514 +0100
+++ b/scripts/lvm2_activation_generator_systemd_red_hat.c	2012-11-24 20:06:56.774634314 +0100
@@ -19,6 +19,7 @@
 #include <sys/types.h>
 #include <sys/stat.h>
 #include <fcntl.h>
+#include <limits.h>		/* for PATH_MAX */
 #include "lvm2app.h"
 
 #define KMSG_DEV_PATH        "/dev/kmsg"

             reply	other threads:[~2013-02-02 16:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-02 16:14 John Spencer [this message]
2013-02-09 23:18 ` [linux-lvm] [PATCH] fix missing include directives John Spencer
2013-02-21 13:42   ` John Spencer
2013-02-21 16:54     ` Zdenek Kabelac
2013-02-21 16:55     ` Zdenek Kabelac

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=510D3B57.3020607@barfooze.de \
    --to=maillist-lvm@barfooze.de \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).