* [linux-lvm] [PATCH] fix missing include directives
@ 2013-02-02 16:14 John Spencer
2013-02-09 23:18 ` John Spencer
0 siblings, 1 reply; 5+ messages in thread
From: John Spencer @ 2013-02-02 16:14 UTC (permalink / raw)
To: linux-lvm
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
on glibc, those are erroneously (namespace pollution) pulled in via
other headers. this doesn't work with conformant libcs (musl libc in
this case), we simply need to include all needed headers.
Signed-Off-By: John Spencer <maillist-lvm@barfooze.de>
[-- Attachment #2: lvm2-includes.patch --]
[-- Type: text/x-patch, Size: 902 bytes --]
--- a/libdm/mm/pool-fast.c 2012-11-24 19:05:17.413015858 +0100
+++ b/libdm/mm/pool-fast.c 2012-11-24 19:05:56.589926540 +0100
@@ -18,6 +18,7 @@
#endif
#include "dmlib.h"
+#include <stddef.h>
#include <malloc.h>
struct chunk {
--- a/daemons/dmeventd/dmeventd.c 2012-11-24 19:08:48.981918074 +0100
+++ b/daemons/dmeventd/dmeventd.c 2012-11-24 19:09:25.822750433 +0100
@@ -37,6 +37,7 @@
#include <unistd.h>
#include <signal.h>
#include <arpa/inet.h> /* for htonl, ntohl */
+#include <fcntl.h>
#ifdef linux
/*
--- a/scripts/lvm2_activation_generator_systemd_red_hat.c 2012-11-24 20:06:19.481792514 +0100
+++ b/scripts/lvm2_activation_generator_systemd_red_hat.c 2012-11-24 20:06:56.774634314 +0100
@@ -19,6 +19,7 @@
#include <sys/types.h>
#include <sys/stat.h>
#include <fcntl.h>
+#include <limits.h> /* for PATH_MAX */
#include "lvm2app.h"
#define KMSG_DEV_PATH "/dev/kmsg"
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-lvm] [PATCH] fix missing include directives
2013-02-02 16:14 [linux-lvm] [PATCH] fix missing include directives John Spencer
@ 2013-02-09 23:18 ` John Spencer
2013-02-21 13:42 ` John Spencer
0 siblings, 1 reply; 5+ messages in thread
From: John Spencer @ 2013-02-09 23:18 UTC (permalink / raw)
To: linux-lvm
On 02/02/2013 05:14 PM, John Spencer wrote:
> on glibc, those are erroneously (namespace pollution) pulled in via
> other headers. this doesn't work with conformant libcs (musl libc in
> this case), we simply need to include all needed headers.
>
> Signed-Off-By: John Spencer <maillist-lvm@barfooze.de>
>
>
ping
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-lvm] [PATCH] fix missing include directives
2013-02-09 23:18 ` John Spencer
@ 2013-02-21 13:42 ` John Spencer
2013-02-21 16:54 ` Zdenek Kabelac
2013-02-21 16:55 ` Zdenek Kabelac
0 siblings, 2 replies; 5+ messages in thread
From: John Spencer @ 2013-02-21 13:42 UTC (permalink / raw)
To: linux-lvm, agk
On 02/10/2013 12:18 AM, John Spencer wrote:
> On 02/02/2013 05:14 PM, John Spencer wrote:
>> on glibc, those are erroneously (namespace pollution) pulled in via
>> other headers. this doesn't work with conformant libcs (musl libc in
>> this case), we simply need to include all needed headers.
>>
>> Signed-Off-By: John Spencer <maillist-lvm@barfooze.de>
>>
>>
>
> ping
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-lvm] [PATCH] fix missing include directives
2013-02-21 13:42 ` John Spencer
@ 2013-02-21 16:54 ` Zdenek Kabelac
2013-02-21 16:55 ` Zdenek Kabelac
1 sibling, 0 replies; 5+ messages in thread
From: Zdenek Kabelac @ 2013-02-21 16:54 UTC (permalink / raw)
To: LVM general discussion and development; +Cc: John Spencer
Dne 21.2.2013 14:42, John Spencer napsal(a):
> On 02/10/2013 12:18 AM, John Spencer wrote:
>> On 02/02/2013 05:14 PM, John Spencer wrote:
>>> on glibc, those are erroneously (namespace pollution) pulled in via
>>> other headers. this doesn't work with conformant libcs (musl libc in
>>> this case), we simply need to include all needed headers.
>>>
>>> Signed-Off-By: John Spencer <maillist-lvm@barfooze.de>
>>>
>>>
>>
>> ping
>
accepted
https://www.redhat.com/archives/lvm-devel/2013-February/msg00033.html
Zdenek
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [linux-lvm] [PATCH] fix missing include directives
2013-02-21 13:42 ` John Spencer
2013-02-21 16:54 ` Zdenek Kabelac
@ 2013-02-21 16:55 ` Zdenek Kabelac
1 sibling, 0 replies; 5+ messages in thread
From: Zdenek Kabelac @ 2013-02-21 16:55 UTC (permalink / raw)
To: LVM general discussion and development; +Cc: John Spencer
Dne 21.2.2013 14:42, John Spencer napsal(a):
> On 02/10/2013 12:18 AM, John Spencer wrote:
>> On 02/02/2013 05:14 PM, John Spencer wrote:
>>> on glibc, those are erroneously (namespace pollution) pulled in via
>>> other headers. this doesn't work with conformant libcs (musl libc in
>>> this case), we simply need to include all needed headers.
>>>
>>> Signed-Off-By: John Spencer <maillist-lvm@barfooze.de>
>>>
>>>
>>
>> ping
>
Accepted
https://www.redhat.com/archives/lvm-devel/2013-February/msg00033.html
Zdenek
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-02-21 16:55 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-02-02 16:14 [linux-lvm] [PATCH] fix missing include directives John Spencer
2013-02-09 23:18 ` John Spencer
2013-02-21 13:42 ` John Spencer
2013-02-21 16:54 ` Zdenek Kabelac
2013-02-21 16:55 ` Zdenek Kabelac
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).