From mboxrd@z Thu Jan  1 00:00:00 1970
Message-ID: <5148A2AE.7030405@barfooze.de>
Date: Tue, 19 Mar 2013 18:38:54 +0100
From: John Spencer <maillist-lvm@barfooze.de>
MIME-Version: 1.0
References: <51082839.5080400@barfooze.de>	<20130130025520.GB868@agk-dp.fab.redhat.com>	<5109E597.5040706@barfooze.de>
	<512A2DC3.6040503@barfooze.de>
In-Reply-To: <512A2DC3.6040503@barfooze.de>
Content-Transfer-Encoding: 7bit
Subject: Re: [linux-lvm] lvm2 portability issues (GNU sed is assumed)
Reply-To: LVM general discussion and development <linux-lvm@redhat.com>
List-Id: LVM general discussion and development <linux-lvm.redhat.com>
List-Unsubscribe: <https://www.redhat.com/mailman/options/linux-lvm>,
	<mailto:linux-lvm-request@redhat.com?subject=unsubscribe>
List-Archive: <https://www.redhat.com/archives/linux-lvm>
List-Post: <mailto:linux-lvm@redhat.com>
List-Help: <mailto:linux-lvm-request@redhat.com?subject=help>
List-Subscribe: <https://www.redhat.com/mailman/listinfo/linux-lvm>,
	<mailto:linux-lvm-request@redhat.com?subject=subscribe>
List-Id: <linux-lvm.redhat.com>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: zkabelac@redhat.com, agk@redhat.com
Cc: LVM general discussion and development <linux-lvm@redhat.com>

On 02/24/2013 04:12 PM, John Spencer wrote:
> On 01/31/2013 04:31 AM, John Spencer wrote:
>> On 01/30/2013 03:55 AM, Alasdair G Kergon wrote:
>>> On Tue, Jan 29, 2013 at 08:51:21PM +0100, John Spencer wrote:
>>>> may i ask kindly to reformulate that statement so that it works with
>>>> posix sed (as used in busybox 1.20.2) ?
>>>
>>> I'm perfectly happy using modern extensions to these tools:)
>>>
>>> If you want this to work with alternative versions, please send a tested
>>> patch for us to incorporate. (Either modifications to the commands so
>>> it works with both or else alternative versions which configure chooses
>>> between.)
>>
>> a couple of regex experts looked at it, and the reason it didnt work is
>> simply a bug: the \ before d is wrong. apparently the author meant to
>> escape the makefile variable that follows, but that is not necessary and
>> so the backslash gets passed on.
>>
>> find attached a patch that works correctly with gnu sed and busybox sed.
>
>
> zdenek, since alasdair does not seem to react, would you mind applying
> this patch for a quick test, see that it generates both linker scripts
> (.export.sym) correctly (exactly the same output than before) and merge
> it ? thanks!
>
> (reattaching the patch)
>
> thanks,
> --JS
>

ping