linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: Tony Asleson <tasleson@redhat.com>
To: linux-lvm@redhat.com
Subject: Re: [linux-lvm] [PATCH 1/2] python: Make lv addTag/removeTag	persistant
Date: Tue, 07 Apr 2015 16:55:29 -0500	[thread overview]
Message-ID: <55245251.1040302@redhat.com> (raw)
In-Reply-To: <20150407210454.GB32694@agk-dp.fab.redhat.com>

On 04/07/2015 04:04 PM, Alasdair G Kergon wrote:
> On Tue, Apr 07, 2015 at 03:54:01PM -0500, Tony Asleson wrote:
>> +    if (lvm_vg_write(self->parent_vgobj->vg) == -1)
> 
> In the end, you may need to make this configurable for the library user
> (consistently over all functions).
> Some users will want to set lots of properties on lots of LVs followed
> by a single atomic commit for them all; whereas other users will want to
> commit each change independently.

If a user wants that level of functionality they can use the C library
interface.  The python interface has only offered the mode where changes
are auto committed.

This is a bug fix to make the lv tag add/remove persist as expected.

-Tony

      reply	other threads:[~2015-04-07 21:55 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-04-07 20:54 [linux-lvm] [PATCH 1/2] python: Make lv addTag/removeTag persistant Tony Asleson
2015-04-07 20:54 ` [linux-lvm] [PATCH 2/2] python unit test ws fixes Tony Asleson
2015-04-07 21:04 ` [linux-lvm] [PATCH 1/2] python: Make lv addTag/removeTag persistant Alasdair G Kergon
2015-04-07 21:55   ` Tony Asleson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55245251.1040302@redhat.com \
    --to=tasleson@redhat.com \
    --cc=linux-lvm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).