linux-lvm.redhat.com archive mirror
 help / color / mirror / Atom feed
From: David Teigland <teigland@redhat.com>
To: Heming Zhao <heming.zhao@suse.com>
Cc: Peter Rajnoha <prajnoha@redhat.com>,
	Martin Wilck <martin.wilck@suse.com>,
	"zkabelac@redhat.com" <zkabelac@redhat.com>,
	"bmarzins@redhat.com" <bmarzins@redhat.com>,
	"linux-lvm@lists.linux.dev" <linux-lvm@lists.linux.dev>,
	Glass Su <glass.su@suse.com>, "hare@suse.de" <hare@suse.de>
Subject: Re: discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83
Date: Wed, 15 Nov 2023 13:12:00 -0600	[thread overview]
Message-ID: <ZVUYAJyEe5fNh4SN@redhat.com> (raw)
In-Reply-To: <037a0ba9-76fc-469c-ac96-11981391903b@suse.com>

On Wed, Nov 15, 2023 at 07:36:57PM +0800, Heming Zhao wrote:
> From the lvm2 code, above description is wrong. By default, system/devices is
> disabled status. Because lvm.conf option "use_devicesfile = 0" by default.
> under "use_devicesfile = 0", any pvcreate/vgcreate/lvmdevices/vgimportdevices
> won't generate/create system/devices file.
> If my watching is correct, part discussion of this thread may invalid.

The lvm default is use_devicesfile=1, as shown in this commit:

commit 6c22392a3f903d6c086f7cc94978bdf8b072da6e
Author: David Teigland <teigland@redhat.com>
Date:   Tue Mar 16 09:52:13 2021 -0500

    config: change default use_devicesfile to 1

diff --git a/lib/config/defaults.h b/lib/config/defaults.h
index 66eece53aa33..a7a2a06df654 100644
--- a/lib/config/defaults.h
+++ b/lib/config/defaults.h
@@ -322,7 +322,7 @@
 
 #define DEFAULT_MD_COMPONENT_CHECKS "auto"
 
-#define DEFAULT_USE_DEVICES_FILE 0
+#define DEFAULT_USE_DEVICES_FILE 1
 #define DEFAULT_DEVICES_FILE "system.devices"


Later commits that removed DEFAULT_USE_DEVICES_FILE, and tried to replace
it with a configure option, was a failed attempt at building that lvm
source for RHEL8.  It's caused no end of problems and I plan to revert it
and restore define DEFAULT_USE_DEVICES_FILE 1.

Dave


  reply	other threads:[~2023-11-15 19:12 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-11 12:51 discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83 Heming Zhao
2023-11-13 11:52 ` Martin Wilck
2023-11-13 13:52   ` Peter Rajnoha
2023-11-13 18:38     ` David Teigland
2023-11-14  7:55       ` Peter Rajnoha
2023-11-14 16:30         ` David Teigland
2023-11-15  8:51           ` Peter Rajnoha
2023-11-15 11:36             ` Heming Zhao
2023-11-15 19:12               ` David Teigland [this message]
2023-11-16 13:37                 ` Zdenek Kabelac
2023-11-16 13:46                   ` Martin Wilck
2023-11-16 14:03                     ` Zdenek Kabelac
2023-11-16 15:29                       ` Martin Wilck
2023-11-16 17:13                         ` David Teigland
2023-11-16 15:10                   ` David Teigland
2023-11-16 15:40                     ` Martin Wilck
2023-11-16 15:48                       ` Zdenek Kabelac
2023-11-16 17:27                         ` David Teigland
2023-11-16 15:59                     ` Zdenek Kabelac
2023-11-17  1:47                   ` Demi Marie Obenour
2023-11-17 15:25                     ` David Teigland
2023-11-17 19:57                       ` Demi Marie Obenour
2023-11-17 20:16                         ` David Teigland
2023-11-17 21:03                           ` Demi Marie Obenour
2023-11-17 21:05                             ` Martin Wilck
2023-11-20 10:13                               ` Zdenek Kabelac
2023-11-15 21:02             ` David Teigland
2023-11-15 21:46               ` Martin Wilck
2023-11-16 16:11                 ` David Teigland
2023-11-14 10:44       ` Martin Wilck
2023-11-14 12:18         ` Heming Zhao
2023-11-14 17:16           ` David Teigland
2023-11-14 17:00         ` David Teigland
2023-11-14 17:48           ` Martin Wilck
2023-11-14 17:58             ` Martin Wilck
2023-11-14 21:02               ` David Teigland
2023-11-15  7:35                 ` Martin Wilck
2023-11-16 16:34                   ` David Teigland
2023-11-16 20:22                     ` Benjamin Marzinski
2023-11-14 20:51             ` David Teigland
2023-11-15  5:15               ` Heming Zhao
2023-11-15  7:39                 ` Martin Wilck
2023-11-21 14:39   ` Martin Wilck
2023-11-21 17:56     ` David Teigland
2023-11-21 18:10       ` Martin Wilck
2023-11-21 18:25         ` David Teigland
2023-11-21 20:35           ` Martin Wilck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZVUYAJyEe5fNh4SN@redhat.com \
    --to=teigland@redhat.com \
    --cc=bmarzins@redhat.com \
    --cc=glass.su@suse.com \
    --cc=hare@suse.de \
    --cc=heming.zhao@suse.com \
    --cc=linux-lvm@lists.linux.dev \
    --cc=martin.wilck@suse.com \
    --cc=prajnoha@redhat.com \
    --cc=zkabelac@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).