From: David Teigland <teigland@redhat.com>
To: Zdenek Kabelac <zkabelac@redhat.com>
Cc: Heming Zhao <heming.zhao@suse.com>,
Peter Rajnoha <prajnoha@redhat.com>,
Martin Wilck <martin.wilck@suse.com>,
"bmarzins@redhat.com" <bmarzins@redhat.com>,
"linux-lvm@lists.linux.dev" <linux-lvm@lists.linux.dev>,
Glass Su <glass.su@suse.com>, "hare@suse.de" <hare@suse.de>
Subject: Re: discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83
Date: Thu, 16 Nov 2023 09:10:45 -0600 [thread overview]
Message-ID: <ZVYw9eNTj7Ir6V31@redhat.com> (raw)
In-Reply-To: <e64bbbc8-1716-4739-a68c-2f92563a9c8d@redhat.com>
On Thu, Nov 16, 2023 at 02:37:13PM +0100, Zdenek Kabelac wrote:
> > and restore define DEFAULT_USE_DEVICES_FILE 1.
>
> There is no problem with configuring DEFAULT_USE_DEVICES_FILE with
> 'configure --with-default-use-devices-file= 0/1' and thus no need to change
> anything here.
>
> Current upstream has set this default value as 0 (in configure.ac)
I didn't realize you'd changed the default, please set it back to 1.
(Even better put back DEFAULT_USE_DEVICES_FILE; configured settings
are a pain to deal with, and the complexity causes real problems.)
> The major problem with turning this to 1 is the distribution must be
> 'ready' with such relatively invasive change as it changes also requirements
> on how the boot image is created (devicesfile must be copied to ramdisk).
While a distribution does want to be aware of the change (discussed
earlier in the thread), what you're saying specifically is not true.
RHEL, which has this enabled, doesn't even have system.devices in the
ramdisk. It simply means that it's not used for activating the root LV.
Dave
next prev parent reply other threads:[~2023-11-16 15:10 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 12:51 discuss about commit 3b0f9ce: filter-mpath: get wwids from sysfs vpd_pg83 Heming Zhao
2023-11-13 11:52 ` Martin Wilck
2023-11-13 13:52 ` Peter Rajnoha
2023-11-13 18:38 ` David Teigland
2023-11-14 7:55 ` Peter Rajnoha
2023-11-14 16:30 ` David Teigland
2023-11-15 8:51 ` Peter Rajnoha
2023-11-15 11:36 ` Heming Zhao
2023-11-15 19:12 ` David Teigland
2023-11-16 13:37 ` Zdenek Kabelac
2023-11-16 13:46 ` Martin Wilck
2023-11-16 14:03 ` Zdenek Kabelac
2023-11-16 15:29 ` Martin Wilck
2023-11-16 17:13 ` David Teigland
2023-11-16 15:10 ` David Teigland [this message]
2023-11-16 15:40 ` Martin Wilck
2023-11-16 15:48 ` Zdenek Kabelac
2023-11-16 17:27 ` David Teigland
2023-11-16 15:59 ` Zdenek Kabelac
2023-11-17 1:47 ` Demi Marie Obenour
2023-11-17 15:25 ` David Teigland
2023-11-17 19:57 ` Demi Marie Obenour
2023-11-17 20:16 ` David Teigland
2023-11-17 21:03 ` Demi Marie Obenour
2023-11-17 21:05 ` Martin Wilck
2023-11-20 10:13 ` Zdenek Kabelac
2023-11-15 21:02 ` David Teigland
2023-11-15 21:46 ` Martin Wilck
2023-11-16 16:11 ` David Teigland
2023-11-14 10:44 ` Martin Wilck
2023-11-14 12:18 ` Heming Zhao
2023-11-14 17:16 ` David Teigland
2023-11-14 17:00 ` David Teigland
2023-11-14 17:48 ` Martin Wilck
2023-11-14 17:58 ` Martin Wilck
2023-11-14 21:02 ` David Teigland
2023-11-15 7:35 ` Martin Wilck
2023-11-16 16:34 ` David Teigland
2023-11-16 20:22 ` Benjamin Marzinski
2023-11-14 20:51 ` David Teigland
2023-11-15 5:15 ` Heming Zhao
2023-11-15 7:39 ` Martin Wilck
2023-11-21 14:39 ` Martin Wilck
2023-11-21 17:56 ` David Teigland
2023-11-21 18:10 ` Martin Wilck
2023-11-21 18:25 ` David Teigland
2023-11-21 20:35 ` Martin Wilck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVYw9eNTj7Ir6V31@redhat.com \
--to=teigland@redhat.com \
--cc=bmarzins@redhat.com \
--cc=glass.su@suse.com \
--cc=hare@suse.de \
--cc=heming.zhao@suse.com \
--cc=linux-lvm@lists.linux.dev \
--cc=martin.wilck@suse.com \
--cc=prajnoha@redhat.com \
--cc=zkabelac@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).