From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f41.google.com (mail-oa1-f41.google.com [209.85.160.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0D691E884 for ; Thu, 15 Aug 2024 06:17:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723702681; cv=none; b=hD5Wl+KTeBQfaEjpxl7OTJBYJtJZX557h2Q2dqUhmPFqLZ2eOc5TZtKSI53eJyP9+7g3BYQ40mKWrO71vj24j6tBOA9dmalhWbtG4wAq9XpNmjwAkc+SgTD0l+ImldlFQHENTo8WabZVE8bhpp29dG8MMi1RYSsYhnFe0ZwHmas= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723702681; c=relaxed/simple; bh=2ieEkSgkeeXHKQaOG4S/bYJ9as9XsQf3erKR7zsdkP4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=TtWLA+p7c5CeSqh+MmmZOEhQdGoavuJzDfLBn3PBX3oYenCtNVFYkWDQYm+kQgYyF54GjSDeA0oAbJzW5TQKnr1i/hsuNduUwXcCDmpfmmtsvWgp6d9qQacHcY1JXC8Zk7u2AZBLNTIYojhNOjVjfOOGjCMJYxO9vTS4dpdi5CU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=GlrRBgKk; arc=none smtp.client-ip=209.85.160.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GlrRBgKk" Received: by mail-oa1-f41.google.com with SMTP id 586e51a60fabf-261112c303bso476016fac.1 for ; Wed, 14 Aug 2024 23:17:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1723702679; x=1724307479; darn=lists.linux-m68k.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=SAHWmUt5jip0y+u22BsHFrHANReT/fLelSD2WuMjZ6U=; b=GlrRBgKk6IbNNP3Wwrk3f3iYJIMt1qBCu5FVNLfAX+zY4HrMsGiBXORLAJ+hN96M6C RS7bsbW45eAmVyj0bn+4/Jt6YEaP1vtM7pPCZPcSWw/z8Pwt6hlD0ekCtY2xfz7Pz9Z3 vdrpEFQXnDPtcF/5Ejrjm7T2+7yaHxUkDrDhysQeD3it7nVUrQqPNBMfRwhE3mDF2YXQ ex+WeDeX33UsW+cboT2yFmtoK3nxJ/w6CP5LmKEonCxF4MS3wBcPHzDDEgSyoV3bI3l7 3on2WPWTLoGgmnmWXlfJUuSl2HyNT5SiwwCvdiO5iKDy/3haio5MxLfABJIYbIuAsjYB a7JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723702679; x=1724307479; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SAHWmUt5jip0y+u22BsHFrHANReT/fLelSD2WuMjZ6U=; b=p36y5jhFXavyQlAsYOdO1KAVRclqPrgyM9OATz2wqgImxP+nTTaOFEreRW941yiiOd rfGk31pjsle33A+Ndm3VjChwRmkTxGdy+hyiQOF6pliUzbO4zp3+WSuO8SKBzgpQKw7z pvwtHVAvJrQf68wsaIHRtb+GGHhWrqgWH3/5M2FEZlaKoePganeCna0KUqgm2mwbu6MB MrLco1rZCkIfZh3xitOSB5YiofRd6PNAy4e11JDo7z+u57xjSgOhGMv2jcSDgRerH+tq DL+9nObJkd1LB959EdQhTntK6WbqAgB+nBKgUpIgdfNMz7COnX8aNVmhA0qY7ux6wx7m UvBw== X-Forwarded-Encrypted: i=1; AJvYcCVaaTRvFX9wgODnhKr0p4jXwpiNQhk/z5EYnleJIXIkRCkxjT3VXC7enOFwv8gm0Fmbcgb2VzDGtcYEOkCXwaHac9I7EBcKOhuYxDUFcIee X-Gm-Message-State: AOJu0Ywy81nqCHNW7icE6kmZojgzDYxEI719aJHpAb/oTZTvR5y9dry4 E/F0g/rmpywrBUSGpwnOlA7cYDvnNW4Rs42J25v+7kI2i64fLfun X-Google-Smtp-Source: AGHT+IGJpazxnkj0vrfs0qcLRP6qpL8RKPrwMyfkdNMVp4bX1EZv/Ik/vGgVpgkEp8G6HmJcF19Ukw== X-Received: by 2002:a05:6870:8a12:b0:258:3455:4b02 with SMTP id 586e51a60fabf-26fe5ca588amr5544755fac.51.1723702678720; Wed, 14 Aug 2024 23:17:58 -0700 (PDT) Received: from [192.168.255.10] ([43.132.141.25]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7127add6b3dsm479443b3a.8.2024.08.14.23.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Aug 2024 23:17:58 -0700 (PDT) Message-ID: <02d7b8a2-b0d6-4713-b03e-5b22968387c3@gmail.com> Date: Thu, 15 Aug 2024 14:17:45 +0800 Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH 00/18] use struct ptdesc to replace pgtable_t To: Matthew Wilcox , alexs@kernel.org Cc: Will Deacon , "Aneesh Kumar K . V" , Nick Piggin , Peter Zijlstra , Russell King , Catalin Marinas , Brian Cain , WANG Xuerui , Geert Uytterhoeven , Jonas Bonn , Stefan Kristiansson , Stafford Horne , Michael Ellerman , Naveen N Rao , Paul Walmsley , Albert Ou , Thomas Gleixner , Borislav Petkov , Dave Hansen , x86@kernel.org, "H . Peter Anvin" , Andy Lutomirski , Bibo Mao , Baolin Wang , linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, loongarch@lists.linux.dev, linux-m68k@lists.linux-m68k.org, linux-openrisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Qi Zheng , Vishal Moola , "Aneesh Kumar K . V" , Kemeng Shi , Lance Yang , Peter Xu , Barry Song , linux-s390@vger.kernel.org, Guo Ren , Christophe Leroy , Palmer Dabbelt , Mike Rapoport , Oscar Salvador , Alexandre Ghiti , Jisheng Zhang , Samuel Holland , Anup Patel , Josh Poimboeuf , Breno Leitao , Alexander Gordeev , Gerald Schaefer , Hugh Dickins , David Hildenbrand , Ryan Roberts References: <20240730064712.3714387-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 8/15/24 1:13 AM, Matthew Wilcox wrote: > On Tue, Jul 30, 2024 at 02:46:54PM +0800, alexs@kernel.org wrote: >> We have struct ptdesc for page table descriptor a year ago, but it >> has no much usages in kernel, while pgtable_t is used widely. > > Hum, I thought I responded to this to point out the problem, but > I don't see the response anywhere, so I'll try again. > >> The pgtable_t is typedefed as 'pte_t *' in sparc, s390, powerpc and m68k >> except SUN3, others archs are all same as 'struct page *'. > > And there's a very good reason for that. On s390 and powerpc (I cannot > speak to the sparc/m68k), each page table is (potentially) smaller > than PAGE_SIZE. So we cannot do what your patch purports to do, as > we would not know whether we're referring to the first or subsequent > page tables contained within a page. >> Maybe at some point in the distant future we'll be able to allocate > a ptdesc per page table instead of per page allocated for use by page > tables. But we cannot do that yet. Got it. Thanks a lot for the info!