From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yx1-f41.google.com (mail-yx1-f41.google.com [74.125.224.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE964314B64 for ; Wed, 7 Jan 2026 09:29:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.224.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767778161; cv=none; b=fJBrejkFe4tgAKD986nkt8GrSAwqirCdZpiQQAcmCM7s+diwOp+Czjryei0ALVMi+iNcrGW82by333t157XXd8P9tA/iMaZvVg//gJ00bQFkVikgH2I3Rkq7ZwX23cq0xet80DGQVdtC2Ng1X6mpZ801WslMQG0WfgscIMnOcoo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767778161; c=relaxed/simple; bh=YskUE8ivh/0bvl2ccHBh6Q13s6fd7XMp1/zObXA0Cvc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=m38J1JTepaMifydpNqVCogqr+CWdvrEPSBYu5R23/RxTRrvPaALHF2fldlIO65fgtZBB8PpR5RmnADR0yeepZMjBPwiht/HaieNilDHFGmMgvcwPpCO0K213Gh/Lc7dJk3dX4mykF1X9CFZ1BSqbPjYPupQpHqZ5eaiNyNfYkzY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=B/7fXovS; arc=none smtp.client-ip=74.125.224.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="B/7fXovS" Received: by mail-yx1-f41.google.com with SMTP id 956f58d0204a3-6446c1a7a1cso1539026d50.3 for ; Wed, 07 Jan 2026 01:29:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767778158; x=1768382958; darn=lists.linux-m68k.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=B/7fXovSO69hqynYFjsfUd4sAuYR/ShEiTVWGDcPZGuxJ4Wxntghv+YqxhTy4p1ytN q3AHh+J39GDEoAEzwNSI9By1P443uJvfb+Y0z/GG11hnuWmplBGCiuGYzTbwg+XIclKR f8I5gRUbEq+Gmvghv6yCd+0imQaiEjSH1m/THFsuSP36Srr9/E1M0zcsf80J8pHt+Ekz D8FpO8jEDvkUk8fjAIa/otEA9E/jv8+lBPobhwJeQ5TS2s1dFOealMffL5ZW05LJAj41 6MMwSQtfkcHEsBfOSyjbZQSa61Md7LoiOMvkT0NYfR24wgUBJcnFesXi0u/cehNgEQlO wBDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767778158; x=1768382958; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=wk512LwmO/uZGHz1Ojwhz3Ek5WphQWvtFTpjZjwnzlQ=; b=ndkeRIIHZZsQQCP5L7PACQ3D1HaclLK6rB/5vm/GzXtoF4vy60HWiYAyFD0FsMhVNV 2wA3ALUwAVMJ9XlPnlZYnc4OMmvG5nhk3sVfHiw5lhJ/9KgPL8irsxLNeeVQ2fejhk5N B+HJfrDmJ6qiaj9EBYDO8WX1aLEwyi+MS+djEb2R+fGVPEEF2cmTUtCIOTCfZ830pNyx I330Cjl7I0B11s6rWDZjk/fv85mjb1T103pr0HRdNGIdsw4jfHLoWxmnheo7STW7IH25 BLNDHGJh5URu31eX5/rsAevuh8PreTSboO6bQFCNVgPVvMGcB09rFWRIofpmJkaTqKiW kU5w== X-Forwarded-Encrypted: i=1; AJvYcCU0aNH9r35mE+Jl9JHMfyA+p7GYhkOWoVPFoGs9gGSPA2wcoMONa5AX3b6z0XxJPkvcSMG07ZsCLUeZ@lists.linux-m68k.org X-Gm-Message-State: AOJu0YyqwWHt7aAuiXQ+aI/MonYcaNPdpN/Wcmpcf1vyAcgJlnK/uW3u 63IeIZjeaaseJklvvqRaqktFoYHuFpJDH/nbxaFHdKD3x59eNtnqGAeg X-Gm-Gg: AY/fxX40xHu6CQl8l7haPUnsjY+as4LheevlETmgBlKaqdu96w7t6F2NXDUF32RgPJQ Dl+utUdtFeoBylE2QpBpJjfj5M0gUd2zjhZQ+9S7w5suVDZ+zduMptu1RbZ86UPKHlhJ08cAJrP gBrv+21BbArZyjM4lUe/HjoeLcUNeDPnihMgTdf9OPYnB8hzoWX7spUfTAreDttfFZa7VkX2UuC U/IgaycOOYcYgcG2u4CBN7aQyEpsC60BvPWcVxD7CgSgZtDZD0oCgGjmd2XnnVcxoz3kSImrgFz jR1A8W+DrJ/CZljhSI7QwlyfAfMgb8uGTmu/Tvvf3iY9xPdZShI04y9F7KTtCpdDNsHwGXRcxzE 5Q7V0o9M6jhe7NRILyZYYw37XqgkLvA2yOXnYUuGjLTIvjU6PTrSVFOhNs6xnyAG7oH0z8ruzWO XmUSUsBESpOetxVUcfv4BY8Wmz4NYjBMrpK1kNfw== X-Google-Smtp-Source: AGHT+IGPYSkTJQTXRdeZJNO0Ptp1UF4C4ZvN+4Y+pwY9mfVj1KcuNobxA+hhEKXT47wj8D4Ny+QBYg== X-Received: by 2002:a05:690e:1483:b0:644:60d9:8654 with SMTP id 956f58d0204a3-64716c69eccmr1598952d50.87.1767778157608; Wed, 07 Jan 2026 01:29:17 -0800 (PST) Received: from [192.168.2.226] (104.194.78.75.16clouds.com. [104.194.78.75]) by smtp.gmail.com with ESMTPSA id 956f58d0204a3-6470d80be64sm1865006d50.6.2026.01.07.01.28.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 07 Jan 2026 01:29:16 -0800 (PST) Message-ID: <080e493a-e4f1-4c97-a3e1-f76f126b5213@gmail.com> Date: Wed, 7 Jan 2026 17:28:36 +0800 Precedence: bulk X-Mailing-List: linux-m68k@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/pgtable: convert pgtable_t to ptdesc pointer To: Mike Rapoport , alexs@kernel.org Cc: Richard Henderson , Matt Turner , Magnus Lindholm , Vineet Gupta , Russell King , Will Deacon , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Peter Zijlstra , Catalin Marinas , Guo Ren , Brian Cain , Huacai Chen , WANG Xuerui , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , Dinh Nguyen , Jonas Bonn , Stefan Kristiansson , Stafford Horne , "James E.J. Bottomley" , Helge Deller , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , Richard Weinberger , Anton Ivanov , Johannes Berg , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , "H. Peter Anvin" , Andy Lutomirski , Chris Zankel , Max Filippov , Arnd Bergmann , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , Michal Hocko , "open list:ALPHA PORT" , open list , "open list:SYNOPSYS ARC ARCHITECTURE" , "moderated list:ARM PORT" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:MMU GATHER AND TLB INVALIDATION" , "open list:C-SKY ARCHITECTURE" , "open list:QUALCOMM HEXAGON ARCHITECTURE" , "open list:LOONGARCH" , "open list:M68K ARCHITECTURE" , "open list:MIPS" , "open list:OPENRISC ARCHITECTURE" , "open list:PARISC ARCHITECTURE" , "open list:RISC-V ARCHITECTURE" , "open list:SUPERH" , "open list:USER-MODE LINUX (UML)" References: <20260107064642.15771-1-alexs@kernel.org> Content-Language: en-US From: Alex Shi In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2026/1/7 17:05, Mike Rapoport wrote: > On Wed, Jan 07, 2026 at 02:46:35PM +0800,alexs@kernel.org wrote: >> From: Alex Shi >> >> After struct ptdesc introduced, pgtable_t should used it instead of old >> struct page pointer. The only thing in the way for this change is just >> pgtable->lru in pgtable_trans_huge_deposit/withdraw. >> >> Let's convert them into ptdesc and use struct ptdesc* as pgtable_t. >> Thanks testing support from kernel test robot >> >> Signed-off-by: Alex Shi >> --- > ... > >> diff --git a/arch/arm/include/asm/pgalloc.h b/arch/arm/include/asm/pgalloc.h >> index a17f01235c29..1a3484c2df4c 100644 >> --- a/arch/arm/include/asm/pgalloc.h >> +++ b/arch/arm/include/asm/pgalloc.h >> @@ -96,12 +96,12 @@ pte_alloc_one(struct mm_struct *mm) >> { >> struct page *pte; >> >> - pte = __pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM); >> + pte = ptdesc_page(__pte_alloc_one(mm, GFP_PGTABLE_USER | PGTABLE_HIGHMEM)); > When ptdesc will be separated from struct page, ptdesc_page() would fail if the > allocation failed. This line should be split into something like > > struct ptdesc *ptdesc = __pte_alloc_one(...); > if (!ptesc) > return NULL; > pte = ptdesc_page(ptdesc); > > Right, I will fix this. and sent the 2nd version. Thanks a lot! >> if (!pte) >> return NULL; >> if (!PageHighMem(pte)) >> clean_pte_table(page_address(pte)); >> - return pte; >> + return page_ptdesc(pte); >> } >> >> static inline void __pmd_populate(pmd_t *pmdp, phys_addr_t pte, > -- Sincerely yours, Mike. >