Re: [PATCH] Fix siginfo._uid bug

[Geert Uytterhoeven <geert@linux-m68k.org>]

On Mon, Oct 26, 2009 at 15:21, Maxim Kuvyrkov <maxim@codesourcery.com> wrote:
> Maxim Kuvyrkov wrote:
>> Maxim Kuvyrkov wrote:
>>> Andreas Schwab wrote:
>>>> Maxim Kuvyrkov <maxim@codesourcery.com> writes:
>>>>
>>>>> The bug is rather elegant and has been present in sources for years.
>>>>
>>>> For more than 9 years, to be precise, when 32 bit uids were introduced.
>>
>> ...
>>>>
>>>> Given that there is no way to keep backward compatibility it might be a
>>>> good opportunity to do same cleanup here.  Like going back to the
>>>> generic layout.
>>>
>>> There is yet another bug in siginfo.  si_sigval is expected to be at the
>>> same offsets in _timer and _rt.  At the moment si_sigval is at offset 8 in
>>> _timer and at offset 6 in _rt (the patch for fixing uids makes that 8@_timer
>>> and 10@_rt).
>>>
>>> This bug causes rt/tst-*timer* tests fail.
>>>
>>> Moving on to the generic version of siginfo.h will certainly fix the
>>> problem, otherwise, one needs to pad extra 2 bytes in _timer.
>>
>> While the discussion is pending, here is an updated version of the patch
>> that also patches up sigval.
>
> Ping?  Broken signal handling is a quite serious bug.
>
> Geert, which option of fixing would you prefer?

Unfortunately I'm far from a signal expert...

Fixing this breaks backwards compatibility, right?
So what are the consequences? Which applications are affected? Just
gdb? So we need a fixed gdb binary in Debian?

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds