Re: [PATCH 17/35] m68k: define PAGE_OFFSET_RAW for ColdFire CPU with MMU enabled

Geert Uytterhoeven
2011-12-25T20:15:55Z

On Fri, Dec 23, 2011 at 04:15, <gerg@snapgear.com> wrote:
> From: Greg Ungerer <gerg@uclinux.org>
>
> The ColdFire CPU configurations need PAGE_OFFSET_RAW set to the base of
> their RAM. It doesn't matter if they are running with the MMU enabled or
> disabled, it is always set to the base of RAM.
>
> We can keep the choices simple here and key of CONFIG_RAMBASE. If it is
> defined we are on a plaftorm (ColdFire or other non-MMU systems) which
> have a configurable RAM base, just use it.
>
> Reported-by: Alexander Stein <alexander.stein@systec-electronic.com>
> Signed-off-by: Greg Ungerer <gerg@uclinux.org>
> Acked-by: Matt Waddel <mwaddel@yahoo.com>
> Acked-by: Kurt Mahan <kmahan@xmission.com>

Acked-by: Geert Uytterhoeven <geert@linux-m68k.org>

but see below ...

> -#ifdef CONFIG_MMU
> -#ifndef CONFIG_SUN3
> +#if defined(CONFIG_RAMBASE)
> +#define PAGE_OFFSET_RAW                CONFIG_RAMBASE
> +#elif !defined(CONFIG_SUN3)
>  #define PAGE_OFFSET_RAW                0x00000000
>  #else
>  #define PAGE_OFFSET_RAW                0x0E000000
>  #endif
> -#else
> -#define        PAGE_OFFSET_RAW         CONFIG_RAMBASE
> -#endif

To avoid alternating between defined and !defined, I'd suggest writing
it instead like:

#if defined(CONFIG_RAMBASE)
#define PAGE_OFFSET_RAW CONFIG_RAMBASE
#elif defined(CONFIG_SUN3)
#define PAGE_OFFSET_RAW 0x0E000000
#else
#define PAGE_OFFSET_RAW 0x00000000
#endif

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds