Re: [PATCH 33/35] m68k: do not use m68k startup or interrupt code for ColdFire CPU's

Greg Ungerer
2011-12-29T02:01:59Z

Hi Geert,

On 28/12/11 20:09, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Wed, Dec 28, 2011 at 01:22, Greg Ungerer<gerg@snapgear.com> wrote:
>> On 28/12/11 04:30, Geert Uytterhoeven wrote:
>>> On Tue, Dec 27, 2011 at 13:24, Greg Ungerer<gerg@snapgear.com> Ã¡wrote:
>>>>>> â”œÃ­extra-$(CONFIG_MMU) â”œÃ­ â”œÃ­ â”œÃ­ â”œÃ­ â”œÃ­ â”œÃ­:= head.o
>>>>>> â”œÃ­extra-$(CONFIG_SUN3) â”œÃ­ := sun3-head.o
>>>>>> +extra-$(CONFIG_COLDFIRE) â”œÃ­ â”œÃ­ â”œÃ­ :=
>>>>>
>>>>> Why do you need the line above?
>>>>
>>>> That is to avoid using a "#ifndef CONFIG_COLDFIRE" around these.
>>>> This entry clears out extra-y for the case when both CONFIG_MMU
>>>> and CONFIG_COLDFIRE are set.
>>>
>>> Ooh, that's ugly, and easily overlooked (I missed it).
>>> So you don't want head.o for Coldfire. What about
>>>
>>> extra-$(CONFIG_MMU_MOTOROLA) := head.o
>>> extra-$(CONFIG_SUN3) Ã¡ := sun3-head.o
>>>
>>> ?
>>>
>>> But since head.o is not really about MMU or not, but about the machine,
>>> perhaps it should be explicitly written as
>>>
>>> extra-$(CONFIG_AMIGA) := head.o
>>> extra-$(CONFIG_ATARI) := head.o
>>> ...
>>> extra-$(CONFIG_SUN3X) := head.o
>>
>>
>> I am happy to do it either way. The second option here will need a
>> longer list. I count 8 machines that use head.o (assuming VME is a
>> single machine type) and 1 that uses sun3-head.o. At least the first
>> option above just has the 2 lines.
>>
>> What is your preference?
>
> The latter, as people are experimenting with MMU-less machines now.

Yep, done. I will send the revised patch here soon.

Regards
Greg

------------------------------------------------------------------------
Greg Ungerer -- Principal Engineer EMAIL: gerg@snapgear.com
SnapGear Group, McAfee PHONE: +61 7 3435 2888
8 Gardner Close FAX: +61 7 3217 5323
Milton, QLD, 4064, Australia WEB: http://www.SnapGear.com