From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A05AC4338F for ; Mon, 26 Jul 2021 14:16:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 56280608FB for ; Mon, 26 Jul 2021 14:16:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234427AbhGZNfn (ORCPT ); Mon, 26 Jul 2021 09:35:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53444 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234528AbhGZNfY (ORCPT ); Mon, 26 Jul 2021 09:35:24 -0400 Received: from mail-pj1-x1029.google.com (mail-pj1-x1029.google.com [IPv6:2607:f8b0:4864:20::1029]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 732E3C0619D1 for ; Mon, 26 Jul 2021 07:14:12 -0700 (PDT) Received: by mail-pj1-x1029.google.com with SMTP id l19so13153323pjz.0 for ; Mon, 26 Jul 2021 07:14:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=tqcfKku5K+eKMzm3aYDMoAoIervJKFFLo6d93VoXYDk=; b=B5mv7NbuM+bJ4uOSp6pSJmB18zx7GeFdn7xwAzYShskM4NsJ09S8WdJELexxrgbF3X I6kIpQ2vIAoacFW/4frb/g0BmSDgLb1Uv7YfOT7cvgetOzWPH6N5VKc2A28huUYxgd6E dMHYIw0TTZI787yyl40eLUqByk4IHn4Lx7ueGZOfL+eP1Ir0RbbVO4UOQqNKwhEM6Yo0 YM9nZioh/yw5A/ZVIZmS39sAmDHDGjoqb3MV7zvYu/7PguikkpzVU16WbiRNnm0CN1Xm aCB8Zngl8mCcZ5uCrNiQAWaC+fznmqU0T9hmQ6XwcL+au+VCA0qfJA037yKFMVBd/MbM fRjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=tqcfKku5K+eKMzm3aYDMoAoIervJKFFLo6d93VoXYDk=; b=N2vbP24hbo7P5em1PEfjk47eG8sXNd3Kd6gdbJEBesqBkOckGeip1cG16MKSk+pPOw MN/dYsSoqnNniW/s9wLyVVxGoxj/RfJndKq5myYrZsQar5p69+iz61gu/ey4CvG8UiS/ TLFaBdxpvRJ/tOau4i9aHaPFc2+fpRSTgSPLpzF6L/jTou6QmhbEojm5X9IrZVw4zzEw hNIO58VALytOlQGtPOkQkwr3xK8UFrdXMRsAeJPK4S8ZfADn4Kn05BI8cROU/os9+Ki1 ohSj2HGmfyPKBjLGIEHBQ3tUAY7kpfErl7ACV5x6ydwQFYxYpFW/jGxo1klqc0YkJOKp NRWw== X-Gm-Message-State: AOAM532kw7XnoRzavKGVslxjc8nU7rYbtoNXSwwT4MVYHAo0sNhvmDoD /o1Y+4y+Qt7grM2LGldsaNw= X-Google-Smtp-Source: ABdhPJzsvhz+FApIdsOFnzCDjuFiU5Nxw25rZAPrAKaxEERtMHP8FJdg+aTEHwGt2Xh3auhDUhzhXw== X-Received: by 2002:a63:149:: with SMTP id 70mr927166pgb.413.1627308851703; Mon, 26 Jul 2021 07:14:11 -0700 (PDT) Received: from [0.0.0.0] (jp.bgp.twd2.net. [2a0c:b641:571::1]) by smtp.gmail.com with ESMTPSA id n12sm47958388pgr.2.2021.07.26.07.14.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Jul 2021 07:14:11 -0700 (PDT) Subject: Re: [PATCH] m68k: Remove redefinitions of `PMD_SIZE`, `PMD_MASK`, etc. To: Geert Uytterhoeven Cc: linux-m68k , Linux Kernel Mailing List , kbuild test robot References: <20210721104318.1070133-1-twd2.me@gmail.com> From: twd2 Message-ID: <117080be-e587-a734-bc6f-8c57488db9dc@gmail.com> Date: Mon, 26 Jul 2021 22:14:05 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-m68k@vger.kernel.org On 2021/7/26 17:23, Geert Uytterhoeven wrote: > Hi Wende, > > On Wed, Jul 21, 2021 at 12:44 PM Wende Tan wrote: >> Remove redefinitions of `PMD_SIZE`, `PMD_MASK`, `PTRS_PER_PMD`, >> and `__PAGETABLE_PMD_FOLDED` when PGTABLE_LEVELS == 2 (i.e. SUN3 || >> COLDFIRE). They have already been defined in >> `asm-generic/pgtable-nopmd.h`. > Thanks for your patch! > >> See also https://lore.kernel.org/lkml/202107201907.lqC6B3dF-lkp@intel.com/#t > I'm a bit confused: is this a new issue introduced by the patch from > the above thread, or is this a pre-existing issue? > If the latter, do you know when it was introduced, and how to reproduce it? I think this is a pre-existing issue, introduced in commit 60e50f34b13e ("m68k: mm: use pgtable-nopXd instead of 4level-fixup") . This commit replaced the usage of `4level-fixup.h` in `pgtable_mm.h` to `pgtable-nop*d.h` and removed the redundent definition of `PMD_SHIFT` but forgot to clean up other macros like `PMD_SIZE` (it should be moved into the `#if` condition) [1]. And, GCC will not complain until two definitions of a macro with the same name differ (as the above thread changes `1UL` to `_UL(1)`), hiding this issue. [1] https://github.com/torvalds/linux/commit/60e50f34b13e9e40763be12aa55f2144d8da514c#diff-9ec45948bad35c0e35d0c2d301a2a643336ff8fe2ee8ea3fff19d8f0bb948a46L34 Thanks. Wende >> Reported-by: kernel test robot >> Signed-off-by: Wende Tan > Gr{oetje,eeting}s, > > Geert >