Re: [PATCH v11 1/3] m68k: amiga/pcmcia - add 16 bit detection interface to amipcmcia.h

Michael Schmitz
2021-11-18T19:43:04Z

Hi Geert,

On 18/11/21 21:09, Geert Uytterhoeven wrote:
>>>> I suggest to move that parameter to arch/m68k/amiga/pcmcia.c to ensure
>>>> it's always visible, and rename it to better reflect its actual function
>>>> (pcmcia_16bit comes to mind). apne.c would then use that parameter to
>>>> autoprobe 16 bit IO support, or set isa_type according to the parameter.
>>>>
>>>> Would that satisfy your concerns, Denis?
>>>
>>> What's the point of the sysfs parameter, given the driver cannot be
>>> unbound and rebound, as it does not use the driver model yet?
>>
>> Pre-setting the desired IO type before loading the module - though
>> actual setting of isa_type still has to wait until module load (or
>> driver probe). I'd have to write a callback that validates user input if
>> we want to set isa_type directly in pcmcia.c ...
>
> IMHO the sysfs parameter would only make sense if all of the 8/16-bit
> handling (and the special reset) is done in arch/m68k/amiga/pcmcia.c,
> so it can be shared for multiple cards.

Do we even have any other cards/drivers that work with the Amiga PCMCIA
port?

>>> The only thing you can (try to) do is unload and reload the module,
>>> at which point you can pass the module parameter again?
>>
>> I take that as 'don't do that', then ... ?
>
> I meant you can do the above without the sysfs parameter.

I wasn't overly clear there - what I meant is, I take your comment to
mean 'don't bother adding a sysfs parameter that does not add any extra
functionality'.

The module parameter will appear in sysfs and can be used to read out
the 16 bit IO state anyway.

Cheers,

Michael

> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
>